Title: [142075] trunk/Source/WebCore
- Revision
- 142075
- Author
- [email protected]
- Date
- 2013-02-07 00:38:55 -0800 (Thu, 07 Feb 2013)
Log Message
Remove DOMWindow::parseModalDialogFeatures()
https://bugs.webkit.org/show_bug.cgi?id=109139
Reviewed by Kent Tamura.
No one uses the method. FIXME is saying:
// FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.
Given that V8's showModalDialog() is now using DOMWindow, we can remove it.
No tests. No change in behavior.
* page/DOMWindow.cpp:
* page/DOMWindow.h:
(DOMWindow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (142074 => 142075)
--- trunk/Source/WebCore/ChangeLog 2013-02-07 08:38:04 UTC (rev 142074)
+++ trunk/Source/WebCore/ChangeLog 2013-02-07 08:38:55 UTC (rev 142075)
@@ -1,3 +1,22 @@
+2013-02-06 Kentaro Hara <[email protected]>
+
+ Remove DOMWindow::parseModalDialogFeatures()
+ https://bugs.webkit.org/show_bug.cgi?id=109139
+
+ Reviewed by Kent Tamura.
+
+ No one uses the method. FIXME is saying:
+
+ // FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.
+
+ Given that V8's showModalDialog() is now using DOMWindow, we can remove it.
+
+ No tests. No change in behavior.
+
+ * page/DOMWindow.cpp:
+ * page/DOMWindow.h:
+ (DOMWindow):
+
2013-02-06 Ilya Tikhonovsky <[email protected]>
Web Inspector: Native Memory Instrumentation: reduce native heap snapshot runtime memory footprint
Modified: trunk/Source/WebCore/page/DOMWindow.cpp (142074 => 142075)
--- trunk/Source/WebCore/page/DOMWindow.cpp 2013-02-07 08:38:04 UTC (rev 142074)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2013-02-07 08:38:55 UTC (rev 142075)
@@ -349,12 +349,6 @@
return window;
}
-// FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.
-void DOMWindow::parseModalDialogFeatures(const String& string, HashMap<String, String>& map)
-{
- WindowFeatures::parseDialogFeatures(string, map);
-}
-
bool DOMWindow::allowPopUp(Frame* firstFrame)
{
ASSERT(firstFrame);
Modified: trunk/Source/WebCore/page/DOMWindow.h (142074 => 142075)
--- trunk/Source/WebCore/page/DOMWindow.h 2013-02-07 08:38:04 UTC (rev 142074)
+++ trunk/Source/WebCore/page/DOMWindow.h 2013-02-07 08:38:55 UTC (rev 142075)
@@ -122,9 +122,6 @@
static FloatRect adjustWindowRect(Page*, const FloatRect& pendingChanges);
- // FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.
- static void parseModalDialogFeatures(const String&, HashMap<String, String>&);
-
bool allowPopUp(); // Call on first window, not target window.
static bool allowPopUp(Frame* firstFrame);
static bool canShowModalDialog(const Frame*);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
