Title: [142156] trunk/Tools
- Revision
- 142156
- Author
- [email protected]
- Date
- 2013-02-07 11:04:26 -0800 (Thu, 07 Feb 2013)
Log Message
Do not check enum's casing for WebKit2 C API.
https://bugs.webkit.org/show_bug.cgi?id=109128
Patch by Eunmi Lee <[email protected]> on 2013-02-07
Reviewed by Kenneth Rohde Christiansen.
Add "-readability/enum_casing" for WebKit2 C APIs because we use word
which starts with non-capital letter 'k' for types of enums.
* Scripts/webkitpy/style/checker.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (142155 => 142156)
--- trunk/Tools/ChangeLog 2013-02-07 19:00:56 UTC (rev 142155)
+++ trunk/Tools/ChangeLog 2013-02-07 19:04:26 UTC (rev 142156)
@@ -1,3 +1,15 @@
+2013-02-07 Eunmi Lee <[email protected]>
+
+ Do not check enum's casing for WebKit2 C API.
+ https://bugs.webkit.org/show_bug.cgi?id=109128
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Add "-readability/enum_casing" for WebKit2 C APIs because we use word
+ which starts with non-capital letter 'k' for types of enums.
+
+ * Scripts/webkitpy/style/checker.py:
+
2013-02-07 Csaba Osztrogonác <[email protected]>
Unreviewed warning fix.
Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (142155 => 142156)
--- trunk/Tools/Scripts/webkitpy/style/checker.py 2013-02-07 19:00:56 UTC (rev 142155)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py 2013-02-07 19:04:26 UTC (rev 142156)
@@ -222,10 +222,13 @@
([# The WebKit2 C API has names with underscores and whitespace-aligned
# struct members. Also, we allow unnecessary parameter names in
# WebKit2 APIs because we're matching CF's header style.
+ # Additionally, we use word which starts with non-capital letter 'k'
+ # for types of enums.
"Source/WebKit2/UIProcess/API/C/",
"Source/WebKit2/Shared/API/c/",
"Source/WebKit2/WebProcess/InjectedBundle/API/c/"],
- ["-readability/naming",
+ ["-readability/enum_casing",
+ "-readability/naming",
"-readability/parameter_name",
"-whitespace/declaration"]),
([# These files define GObjects, which implies some definitions of
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
