Title: [142176] trunk/Source/WebCore
Revision
142176
Author
[email protected]
Date
2013-02-07 13:55:41 -0800 (Thu, 07 Feb 2013)

Log Message

[Mac] decrease in-band caption advance notice interval
https://bugs.webkit.org/show_bug.cgi?id=109190

Reviewed by Simon Fraser.

No new tests, no observable change in behavior.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Request cues 2 seconds in advance.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (142175 => 142176)


--- trunk/Source/WebCore/ChangeLog	2013-02-07 21:49:18 UTC (rev 142175)
+++ trunk/Source/WebCore/ChangeLog	2013-02-07 21:55:41 UTC (rev 142176)
@@ -1,3 +1,15 @@
+2013-02-07  Eric Carlson  <[email protected]>
+
+        [Mac] decrease in-band caption advance notice interval
+        https://bugs.webkit.org/show_bug.cgi?id=109190
+
+        Reviewed by Simon Fraser.
+
+        No new tests, no observable change in behavior.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Request cues 2 seconds in advance.
+
 2013-02-07  ChangSeok Oh  <[email protected]>
 
         [GTK][AC] Clutter required version up to 1.12

Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (142175 => 142176)


--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2013-02-07 21:49:18 UTC (rev 142175)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2013-02-07 21:55:41 UTC (rev 142176)
@@ -905,6 +905,8 @@
         return;
 
 #if HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
+    const NSTimeInterval legibleOutputAdvanceInterval = 2;
+
     if (m_avPlayerItem && !m_legibleOutput) {
         m_legibleOutput = adoptNS([[AVPlayerItemLegibleOutput alloc] initWithMediaSubtypesForNativeRepresentation:[NSArray array]]);
         [m_legibleOutput.get() setSuppressesPlayerRendering:YES];
@@ -914,7 +916,7 @@
         [m_avPlayerItem.get() selectMediaOption:nil inMediaSelectionGroup:[m_avAsset.get() mediaSelectionGroupForMediaCharacteristic:AVMediaCharacteristicLegible]];
 
         [m_legibleOutput.get() setDelegate:m_objcObserver.get() queue:dispatch_get_main_queue()];
-        [m_legibleOutput.get() setAdvanceIntervalForDelegateInvocation:NSTimeIntervalSince1970];
+        [m_legibleOutput.get() setAdvanceIntervalForDelegateInvocation:legibleOutputAdvanceInterval];
         [m_legibleOutput.get() setTextStylingResolution:AVPlayerItemLegibleOutputTextStylingResolutionSourceAndRulesOnly];
         [m_avPlayerItem.get() addOutput:m_legibleOutput.get()];
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to