Title: [142221] trunk/Source/WebCore
Revision
142221
Author
[email protected]
Date
2013-02-07 20:16:53 -0800 (Thu, 07 Feb 2013)

Log Message

Followup review suggestions from Alexey Proskuryakov on
https://bugs.webkit.org/show_bug.cgi?id=109215

Don't provide a charset on embedded SVG, especially
with incorrect syntax :)

* css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-toggle-closed-captions-button):
(video::-webkit-media-controls-closed-captions-track-list li.selected):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (142220 => 142221)


--- trunk/Source/WebCore/ChangeLog	2013-02-08 03:01:40 UTC (rev 142220)
+++ trunk/Source/WebCore/ChangeLog	2013-02-08 04:16:53 UTC (rev 142221)
@@ -1,3 +1,16 @@
+2013-02-07  Dean Jackson  <[email protected]>
+
+        Followup review suggestions from Alexey Proskuryakov on
+        https://bugs.webkit.org/show_bug.cgi?id=109215
+
+        Don't provide a charset on embedded SVG, especially
+        with incorrect syntax :)
+
+        * css/mediaControlsQuickTime.css:
+        (video::-webkit-media-controls-toggle-closed-captions-button):
+        (video::-webkit-media-controls-closed-captions-track-list li.selected):
+        (video::-webkit-media-controls-closed-captions-track-list li.selected:hover):
+
 2013-02-07  Seulgi Kim  <[email protected]>
 
         [Gtk] RunLoop::run shuold run current thread's run loop.

Modified: trunk/Source/WebCore/css/mediaControlsQuickTime.css (142220 => 142221)


--- trunk/Source/WebCore/css/mediaControlsQuickTime.css	2013-02-08 03:01:40 UTC (rev 142220)
+++ trunk/Source/WebCore/css/mediaControlsQuickTime.css	2013-02-08 04:16:53 UTC (rev 142221)
@@ -238,7 +238,7 @@
     margin-right: 7px;
     -webkit-box-ordinal-group: 3; /* between mute and fullscreen */
     border: none !important;
-    background-image: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 130 105"><g fill="rgb(224,224,224)"><path d="M98.766,43.224c0-23.163-21.775-41.94-48.637-41.94c-26.859,0-48.635,18.777-48.635,41.94c0,18.266,13.546,33.796,32.444,39.549c1.131,8.356,26.037,24.255,22.864,19.921c-4.462-6.096-5.159-13.183-5.07-17.566C77.85,84.397,98.766,65.923,98.766,43.224z"/><polygon points="128.044,84 100.956,84 114.5,98"/></g></svg>');
+    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 130 105"><g fill="rgb(224,224,224)"><path d="M98.766,43.224c0-23.163-21.775-41.94-48.637-41.94c-26.859,0-48.635,18.777-48.635,41.94c0,18.266,13.546,33.796,32.444,39.549c1.131,8.356,26.037,24.255,22.864,19.921c-4.462-6.096-5.159-13.183-5.07-17.566C77.85,84.397,98.766,65.923,98.766,43.224z"/><polygon points="128.044,84 100.956,84 114.5,98"/></g></svg>');
     background-repeat: no-repeat;
     background-size: 16px 16px;
 }
@@ -309,14 +309,14 @@
 }
 
 video::-webkit-media-controls-closed-captions-track-list li.selected {
-    background-image: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 300 300"><polygon fill="#a3a3a3" points="252.301,4.477 126.667,194.104 43.358,108.3 6.868,161.408 132.515,290.814 297.732,49.926"/></svg>');
+    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 300 300"><polygon fill="#a3a3a3" points="252.301,4.477 126.667,194.104 43.358,108.3 6.868,161.408 132.515,290.814 297.732,49.926"/></svg>');
     background-repeat: no-repeat;
     background-position: 17px 0.25em;
     background-size: 1.1em 1.1em;
 }
 
 video::-webkit-media-controls-closed-captions-track-list li.selected:hover {
-    background-image: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 300 300"><polygon fill="white" points="252.301,4.477 126.667,194.104 43.358,108.3 6.868,161.408 132.515,290.814 297.732,49.926"/></svg>'), -webkit-gradient(linear, left top, left bottom, color-stop(0, #4f70f6), color-stop(1, #1a44f3));
+    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 300 300"><polygon fill="white" points="252.301,4.477 126.667,194.104 43.358,108.3 6.868,161.408 132.515,290.814 297.732,49.926"/></svg>'), -webkit-gradient(linear, left top, left bottom, color-stop(0, #4f70f6), color-stop(1, #1a44f3));
     background-repeat: no-repeat, repeat;
     background-position: 17px 0.25em, top left;
     background-size: 1.1em 1.1em, 100% 100%;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to