Title: [142226] trunk/Source/WebCore
- Revision
- 142226
- Author
- [email protected]
- Date
- 2013-02-07 21:37:26 -0800 (Thu, 07 Feb 2013)
Log Message
[V8] enum V8HiddenPropertyCreationType is not used
https://bugs.webkit.org/show_bug.cgi?id=109250
Reviewed by Adam Barth.
V8HiddenPropertyCreationType is always NewSymbol. We can remove the enum.
No tests. No change in behavior.
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::hiddenReferenceName):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (142225 => 142226)
--- trunk/Source/WebCore/ChangeLog 2013-02-08 05:32:45 UTC (rev 142225)
+++ trunk/Source/WebCore/ChangeLog 2013-02-08 05:37:26 UTC (rev 142226)
@@ -1,3 +1,19 @@
+2013-02-07 Kentaro Hara <[email protected]>
+
+ [V8] enum V8HiddenPropertyCreationType is not used
+ https://bugs.webkit.org/show_bug.cgi?id=109250
+
+ Reviewed by Adam Barth.
+
+ V8HiddenPropertyCreationType is always NewSymbol. We can remove the enum.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/V8HiddenPropertyName.cpp:
+ (WebCore::hiddenReferenceName):
+ * bindings/v8/V8HiddenPropertyName.h:
+ (WebCore):
+
2013-02-07 Sheriff Bot <[email protected]>
Unreviewed, rolling out r142212.
Modified: trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp (142225 => 142226)
--- trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp 2013-02-08 05:32:45 UTC (rev 142225)
+++ trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp 2013-02-08 05:37:26 UTC (rev 142226)
@@ -55,20 +55,13 @@
V8_HIDDEN_PROPERTIES(V8_DEFINE_HIDDEN_PROPERTY);
-static v8::Handle<v8::String> hiddenReferenceName(const char* name, unsigned length, V8HiddenPropertyCreationType type = NewSymbol)
+static v8::Handle<v8::String> hiddenReferenceName(const char* name, unsigned length)
{
ASSERT(length);
Vector<char, 64> prefixedName;
prefixedName.append(V8_HIDDEN_PROPERTY_PREFIX, sizeof(V8_HIDDEN_PROPERTY_PREFIX) - 1);
prefixedName.append(name, length);
- switch (type) {
- case NewSymbol:
- return v8::String::NewSymbol(prefixedName.data(), static_cast<int>(prefixedName.size()));
- case NewString:
- return v8::String::New(prefixedName.data(), static_cast<int>(prefixedName.size()));
- }
- ASSERT_NOT_REACHED();
- return v8::Handle<v8::String>();
+ return v8::String::NewSymbol(prefixedName.data(), static_cast<int>(prefixedName.size()));
}
void V8HiddenPropertyName::setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child)
Modified: trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h (142225 => 142226)
--- trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h 2013-02-08 05:32:45 UTC (rev 142225)
+++ trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h 2013-02-08 05:37:26 UTC (rev 142226)
@@ -48,8 +48,6 @@
V(toStringString) \
V(typedArrayHiddenCopyMethod)
-enum V8HiddenPropertyCreationType { NewSymbol, NewString };
-
class V8HiddenPropertyName {
public:
V8HiddenPropertyName() { }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
