Title: [142241] trunk/Source/WebCore
Revision
142241
Author
[email protected]
Date
2013-02-08 00:18:04 -0800 (Fri, 08 Feb 2013)

Log Message

Web Inspector: Native Memory Instrumentation: adjust chunk transfer size for better speed.
https://bugs.webkit.org/show_bug.cgi?id=109263

Reviewed by Yury Semikhatsky.

The chunk size is changed from 100 to 10000.
addString counts only first 256 symbols of the string.o

* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::pushUpdateIfNeeded):
(WebCore::HeapGraphSerializer::addString):
* inspector/front-end/NativeMemorySnapshotView.js:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (142240 => 142241)


--- trunk/Source/WebCore/ChangeLog	2013-02-08 08:05:49 UTC (rev 142240)
+++ trunk/Source/WebCore/ChangeLog	2013-02-08 08:18:04 UTC (rev 142241)
@@ -1,3 +1,18 @@
+2013-02-08  Ilya Tikhonovsky  <[email protected]>
+
+        Web Inspector: Native Memory Instrumentation: adjust chunk transfer size for better speed.
+        https://bugs.webkit.org/show_bug.cgi?id=109263
+
+        Reviewed by Yury Semikhatsky.
+
+        The chunk size is changed from 100 to 10000.
+        addString counts only first 256 symbols of the string.o
+
+        * inspector/HeapGraphSerializer.cpp:
+        (WebCore::HeapGraphSerializer::pushUpdateIfNeeded):
+        (WebCore::HeapGraphSerializer::addString):
+        * inspector/front-end/NativeMemorySnapshotView.js:
+
 2013-02-08  Kentaro Hara  <[email protected]>
 
         Support a relatedTarget attribute on focus/blur events

Modified: trunk/Source/WebCore/inspector/HeapGraphSerializer.cpp (142240 => 142241)


--- trunk/Source/WebCore/inspector/HeapGraphSerializer.cpp	2013-02-08 08:05:49 UTC (rev 142240)
+++ trunk/Source/WebCore/inspector/HeapGraphSerializer.cpp	2013-02-08 08:18:04 UTC (rev 142241)
@@ -69,7 +69,7 @@
 
 void HeapGraphSerializer::pushUpdateIfNeeded()
 {
-    static const size_t chunkSize = 100;
+    static const size_t chunkSize = 10000;
     static const size_t averageEdgesPerNode = 5;
 
     if (m_strings->length() <= chunkSize
@@ -174,7 +174,7 @@
 {
     if (string.isEmpty())
         return 0;
-    StringMap::AddResult result = m_stringToIndex.add(string, m_stringToIndex.size() + 1);
+    StringMap::AddResult result = m_stringToIndex.add(string.left(256), m_stringToIndex.size() + 1);
     if (result.isNewEntry)
         m_strings->addItem(string);
     return result.iterator->value;

Modified: trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js (142240 => 142241)


--- trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js	2013-02-08 08:05:49 UTC (rev 142240)
+++ trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js	2013-02-08 08:18:04 UTC (rev 142241)
@@ -232,9 +232,6 @@
     __proto__: WebInspector.DataGridNode.prototype
 }
 
-
-
-
 /**
  * @constructor
  * @extends {WebInspector.ProfileType}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to