Title: [142265] trunk/Source/WebCore
Revision
142265
Author
[email protected]
Date
2013-02-08 05:35:09 -0800 (Fri, 08 Feb 2013)

Log Message

[GTK][AC] GraphicsLayerClutter doesn't need to recalculate its position after changing anchor position.
https://bugs.webkit.org/show_bug.cgi?id=109226

Patch by ChangSeok Oh <[email protected]> on 2013-02-08
Reviewed by Gustavo Noronha Silva.

Clutter has a different coordinate system from mac port's, so we don't need to
recalulate GraphicsLayer position after changing its anchor position.

Covered by existing ac tests.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::updateGeometry):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (142264 => 142265)


--- trunk/Source/WebCore/ChangeLog	2013-02-08 13:16:30 UTC (rev 142264)
+++ trunk/Source/WebCore/ChangeLog	2013-02-08 13:35:09 UTC (rev 142265)
@@ -1,3 +1,18 @@
+2013-02-08  ChangSeok Oh  <[email protected]>
+
+        [GTK][AC] GraphicsLayerClutter doesn't need to recalculate its position after changing anchor position.
+        https://bugs.webkit.org/show_bug.cgi?id=109226
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Clutter has a different coordinate system from mac port's, so we don't need to
+        recalulate GraphicsLayer position after changing its anchor position.
+
+        Covered by existing ac tests.
+
+        * platform/graphics/clutter/GraphicsLayerClutter.cpp:
+        (WebCore::GraphicsLayerClutter::updateGeometry):
+
 2013-02-08  Mike West  <[email protected]>
 
         Migrate ExceptionCode ASSERTs in IDB to ASSERT_NO_EXCEPTION.

Modified: trunk/Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp (142264 => 142265)


--- trunk/Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp	2013-02-08 13:16:30 UTC (rev 142264)
+++ trunk/Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp	2013-02-08 13:35:09 UTC (rev 142265)
@@ -494,21 +494,10 @@
 
 void GraphicsLayerClutter::updateGeometry(float pageScaleFactor, const FloatPoint& positionRelativeToBase)
 {
-    FloatPoint scaledPosition;
-    FloatPoint3D scaledAnchorPoint;
-    FloatSize scaledSize;
-
-    // FIXME: Need to support scaling
-    scaledPosition = m_position;
-    scaledAnchorPoint = m_anchorPoint;
-    scaledSize = m_size;
-
-    FloatRect adjustedBounds(m_boundsOrigin , scaledSize);
-    FloatPoint adjustedPosition(scaledPosition.x() + scaledAnchorPoint.x() * scaledSize.width(), scaledPosition.y() + scaledAnchorPoint.y() * scaledSize.height());
-
-    clutter_actor_set_size(CLUTTER_ACTOR(m_layer.get()), adjustedBounds.width(), adjustedBounds.height());
-    clutter_actor_set_position(CLUTTER_ACTOR(m_layer.get()), adjustedPosition.x(), adjustedPosition.y());
-    graphicsLayerActorSetAnchorPoint(m_layer.get(), scaledAnchorPoint.x(), scaledAnchorPoint.y(), scaledAnchorPoint.z());
+    // FIXME: Need to support page scaling.
+    clutter_actor_set_position(CLUTTER_ACTOR(m_layer.get()), m_position.x(), m_position.y());
+    clutter_actor_set_size(CLUTTER_ACTOR(m_layer.get()), m_size.width(), m_size.height());
+    graphicsLayerActorSetAnchorPoint(m_layer.get(), m_anchorPoint.x(), m_anchorPoint.y(), m_anchorPoint.z());
 }
 
 // Each GraphicsLayer has the corresponding layer in the platform port.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to