Title: [142275] branches/chromium/1364/Source/WebKit/chromium
- Revision
- 142275
- Author
- [email protected]
- Date
- 2013-02-08 07:02:57 -0800 (Fri, 08 Feb 2013)
Log Message
Merge 141904
> [chromium] Make overlay layers slow-scrolling
> https://bugs.webkit.org/show_bug.cgi?id=108957
>
> Patch by Sami Kyostila <[email protected]> on 2013-02-05
> Reviewed by James Robinson.
>
> Since overlay layers get inserted on top of everything else, we must
> mark them slow-scrolling to prevent all scroll input events to the rest
> of the page from getting blocked. This is also more correct because
> generally the overlay contents need to be repainted whenever the scroll
> offset changes, and with this patch the painting happens in sync with
> page scrolling.
[email protected]
Review URL: https://codereview.chromium.org/12210085
Modified Paths
Diff
Modified: branches/chromium/1364/Source/WebKit/chromium/ChangeLog (142274 => 142275)
--- branches/chromium/1364/Source/WebKit/chromium/ChangeLog 2013-02-08 14:50:40 UTC (rev 142274)
+++ branches/chromium/1364/Source/WebKit/chromium/ChangeLog 2013-02-08 15:02:57 UTC (rev 142275)
@@ -1,3 +1,17 @@
+2013-02-05 Sami Kyostila <[email protected]>
+
+ [chromium] Make overlay layers slow-scrolling
+ https://bugs.webkit.org/show_bug.cgi?id=108957
+
+ Reviewed by James Robinson.
+
+ Since overlay layers get inserted on top of everything else, we must
+ mark them slow-scrolling to prevent all scroll input events to the rest
+ of the page from getting blocked. This is also more correct because
+ generally the overlay contents need to be repainted whenever the scroll
+ offset changes, and with this patch the painting happens in sync with
+ page scrolling.
+
2013-01-31 Aurimas Liutikas <[email protected]>
[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
Modified: branches/chromium/1364/Source/WebKit/chromium/src/PageOverlay.cpp (142274 => 142275)
--- branches/chromium/1364/Source/WebKit/chromium/src/PageOverlay.cpp 2013-02-08 14:50:40 UTC (rev 142274)
+++ branches/chromium/1364/Source/WebKit/chromium/src/PageOverlay.cpp 2013-02-08 15:02:57 UTC (rev 142275)
@@ -30,6 +30,7 @@
#include "PageOverlay.h"
#include "GraphicsLayer.h"
+#include "GraphicsLayerChromium.h"
#include "GraphicsLayerClient.h"
#include "Page.h"
#include "PlatformContextSkia.h"
@@ -37,6 +38,7 @@
#include "WebPageOverlay.h"
#include "WebViewClient.h"
#include "WebViewImpl.h"
+#include <public/WebLayer.h>
using namespace WebCore;
@@ -141,6 +143,9 @@
m_viewImpl->setOverlayLayer(m_layer.get());
m_layer->setNeedsDisplay();
+
+ WebLayer* platformLayer = static_cast<GraphicsLayerChromium*>(m_layer.get())->platformLayer();
+ platformLayer->setShouldScrollOnMainThread(true);
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
