Title: [142290] trunk
Revision
142290
Author
[email protected]
Date
2013-02-08 09:12:32 -0800 (Fri, 08 Feb 2013)

Log Message

[Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=109272

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

We enabled this flag for desktop Chromium, but disabled the feature by a
runtime flag. We disables the compile flag too because we have no plan
to ship it in near future.

* features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.

LayoutTests:

* platform/chromium/TestExpectations:
Skip fast/forms/datetime and datetime-multiple-fields

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (142289 => 142290)


--- trunk/LayoutTests/ChangeLog	2013-02-08 17:05:28 UTC (rev 142289)
+++ trunk/LayoutTests/ChangeLog	2013-02-08 17:12:32 UTC (rev 142290)
@@ -1,3 +1,13 @@
+2013-02-08  Kent Tamura  <[email protected]>
+
+        [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
+        https://bugs.webkit.org/show_bug.cgi?id=109272
+
+        Reviewed by Kentaro Hara.
+
+        * platform/chromium/TestExpectations:
+        Skip fast/forms/datetime and datetime-multiple-fields
+
 2013-02-08  Stephen Chenney  <[email protected]>
 
         Expectations as a result of removing Skia code suppressions

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (142289 => 142290)


--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-08 17:05:28 UTC (rev 142289)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-02-08 17:12:32 UTC (rev 142290)
@@ -938,6 +938,21 @@
 # Chromium disabled web intents
 crbug.com/173194 webintents [ Skip ]
 
+# We disabled INPUT_TYPE_DATETIME.
+webkit.org/b/109272 fast/forms/datetime [ Skip ]
+webkit.org/b/109272 fast/forms/datetime-multiple-fields [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html [ Skip ]
+
 # Skipping rules for ANDROID are in platform/chromium-android/TestExpectations.
 
 # -----------------------------------------------------------------

Modified: trunk/Source/WebCore/html/InputType.h (142289 => 142290)


--- trunk/Source/WebCore/html/InputType.h	2013-02-08 17:05:28 UTC (rev 142289)
+++ trunk/Source/WebCore/html/InputType.h	2013-02-08 17:12:32 UTC (rev 142290)
@@ -326,5 +326,4 @@
 };
 
 } // namespace WebCore
-
 #endif

Modified: trunk/Source/WebKit/chromium/ChangeLog (142289 => 142290)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-08 17:05:28 UTC (rev 142289)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-08 17:12:32 UTC (rev 142290)
@@ -1,3 +1,16 @@
+2013-02-08  Kent Tamura  <[email protected]>
+
+        [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
+        https://bugs.webkit.org/show_bug.cgi?id=109272
+
+        Reviewed by Kentaro Hara.
+
+        We enabled this flag for desktop Chromium, but disabled the feature by a
+        runtime flag. We disables the compile flag too because we have no plan
+        to ship it in near future.
+
+        * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
+
 2013-02-08  Stephen Chenney  <[email protected]>
 
         Remove Skia code suppressions

Modified: trunk/Source/WebKit/chromium/features.gypi (142289 => 142290)


--- trunk/Source/WebKit/chromium/features.gypi	2013-02-08 17:05:28 UTC (rev 142289)
+++ trunk/Source/WebKit/chromium/features.gypi	2013-02-08 17:12:32 UTC (rev 142290)
@@ -168,7 +168,6 @@
           'ENABLE_FAST_MOBILE_SCROLLING=1',
           'ENABLE_INPUT_SPEECH=0',
           'ENABLE_INPUT_TYPE_COLOR=0',
-          'ENABLE_INPUT_TYPE_DATETIME=0',
           'ENABLE_INPUT_TYPE_WEEK=0',
           'ENABLE_LEGACY_NOTIFICATIONS=0',
           'ENABLE_MEDIA_CAPTURE=1',
@@ -190,7 +189,6 @@
           'ENABLE_DATALIST_ELEMENT=1',
           'ENABLE_INPUT_SPEECH=1',
           'ENABLE_INPUT_TYPE_COLOR=1',
-          'ENABLE_INPUT_TYPE_DATETIME=1',
           'ENABLE_INPUT_TYPE_WEEK=1',
           'ENABLE_INPUT_MULTIPLE_FIELDS_UI=1',
           'ENABLE_LEGACY_NOTIFICATIONS=1',
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to