Title: [142350] trunk/Source/WebKit2
- Revision
- 142350
- Author
- [email protected]
- Date
- 2013-02-08 22:13:40 -0800 (Fri, 08 Feb 2013)
Log Message
Fix ASSERT when the Web Content Process crashes
https://bugs.webkit.org/show_bug.cgi?id=109346
Reviewed by Simon Fraser.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
We need to remove ourselves as a message receiver before calling out to the client, as
the client might want to re-add us (as Safari does).
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (142349 => 142350)
--- trunk/Source/WebKit2/ChangeLog 2013-02-09 05:52:53 UTC (rev 142349)
+++ trunk/Source/WebKit2/ChangeLog 2013-02-09 06:13:40 UTC (rev 142350)
@@ -1,3 +1,15 @@
+2013-02-08 Sam Weinig <[email protected]>
+
+ Fix ASSERT when the Web Content Process crashes
+ https://bugs.webkit.org/show_bug.cgi?id=109346
+
+ Reviewed by Simon Fraser.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::processDidCrash):
+ We need to remove ourselves as a message receiver before calling out to the client, as
+ the client might want to re-add us (as Safari does).
+
2013-02-08 Benjamin Poulain <[email protected]>
Move workerThreadCount from TestRunner to WebCore Internals
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (142349 => 142350)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-02-09 05:52:53 UTC (rev 142349)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2013-02-09 06:13:40 UTC (rev 142350)
@@ -3563,6 +3563,8 @@
{
ASSERT(m_pageClient);
+ m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID);
+
m_isValid = false;
m_isPageSuspended = false;
@@ -3678,8 +3680,6 @@
dismissCorrectionPanel(ReasonForDismissingAlternativeTextIgnored);
m_pageClient->dismissDictionaryLookupPanel();
#endif
-
- m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID);
}
WebPageCreationParameters WebPageProxy::creationParameters() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
