Title: [142368] trunk/Source/WebCore
- Revision
- 142368
- Author
- [email protected]
- Date
- 2013-02-09 10:35:47 -0800 (Sat, 09 Feb 2013)
Log Message
AX: Rename AXObject::cachedIsIgnoredValue to lastKnownIsIgnoredValue
https://bugs.webkit.org/show_bug.cgi?id=108238
Reviewed by Chris Fleizach.
Simple refactoring, no new tests.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::childrenChanged):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::lastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::setLastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (142367 => 142368)
--- trunk/Source/WebCore/ChangeLog 2013-02-09 18:34:02 UTC (rev 142367)
+++ trunk/Source/WebCore/ChangeLog 2013-02-09 18:35:47 UTC (rev 142368)
@@ -1,3 +1,23 @@
+2013-02-09 Dominic Mazzoni <[email protected]>
+
+ AX: Rename AXObject::cachedIsIgnoredValue to lastKnownIsIgnoredValue
+ https://bugs.webkit.org/show_bug.cgi?id=108238
+
+ Reviewed by Chris Fleizach.
+
+ Simple refactoring, no new tests.
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::getOrCreate):
+ (WebCore::AXObjectCache::childrenChanged):
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::AccessibilityObject):
+ (WebCore::AccessibilityObject::lastKnownIsIgnoredValue):
+ (WebCore::AccessibilityObject::setLastKnownIsIgnoredValue):
+ (WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
+ * accessibility/AccessibilityObject.h:
+ (AccessibilityObject):
+
2013-02-09 Anton Vayvod <[email protected]>
[Text Autosizing] Cleanup change: converter the pointer argument to be a reference since
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (142367 => 142368)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2013-02-09 18:34:02 UTC (rev 142367)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2013-02-09 18:35:47 UTC (rev 142368)
@@ -368,7 +368,7 @@
m_objects.set(newObj->axObjectID(), newObj);
newObj->init();
attachWrapper(newObj.get());
- newObj->setCachedIsIgnoredValue(newObj->accessibilityIsIgnored());
+ newObj->setLastKnownIsIgnoredValue(newObj->accessibilityIsIgnored());
return newObj.get();
}
@@ -392,7 +392,7 @@
m_objects.set(newObj->axObjectID(), newObj);
newObj->init();
attachWrapper(newObj.get());
- newObj->setCachedIsIgnoredValue(newObj->accessibilityIsIgnored());
+ newObj->setLastKnownIsIgnoredValue(newObj->accessibilityIsIgnored());
return newObj.get();
}
@@ -617,7 +617,7 @@
obj->childrenChanged();
- if (obj->parentObjectIfExists() && obj->cachedIsIgnoredValue() != obj->accessibilityIsIgnored())
+ if (obj->parentObjectIfExists() && obj->lastKnownIsIgnoredValue() != obj->accessibilityIsIgnored())
childrenChanged(obj->parentObject());
}
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (142367 => 142368)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2013-02-09 18:34:02 UTC (rev 142367)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2013-02-09 18:35:47 UTC (rev 142368)
@@ -74,7 +74,7 @@
: m_id(0)
, m_haveChildren(false)
, m_role(UnknownRole)
- , m_cachedIsIgnoredValue(DefaultBehavior)
+ , m_lastKnownIsIgnoredValue(DefaultBehavior)
#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
, m_wrapper(0)
#elif PLATFORM(CHROMIUM)
@@ -1782,25 +1782,25 @@
}
}
-bool AccessibilityObject::cachedIsIgnoredValue()
+bool AccessibilityObject::lastKnownIsIgnoredValue()
{
- if (m_cachedIsIgnoredValue == DefaultBehavior)
- m_cachedIsIgnoredValue = accessibilityIsIgnored() ? IgnoreObject : IncludeObject;
+ if (m_lastKnownIsIgnoredValue == DefaultBehavior)
+ m_lastKnownIsIgnoredValue = accessibilityIsIgnored() ? IgnoreObject : IncludeObject;
- return m_cachedIsIgnoredValue == IgnoreObject;
+ return m_lastKnownIsIgnoredValue == IgnoreObject;
}
-void AccessibilityObject::setCachedIsIgnoredValue(bool isIgnored)
+void AccessibilityObject::setLastKnownIsIgnoredValue(bool isIgnored)
{
- m_cachedIsIgnoredValue = isIgnored ? IgnoreObject : IncludeObject;
+ m_lastKnownIsIgnoredValue = isIgnored ? IgnoreObject : IncludeObject;
}
void AccessibilityObject::notifyIfIgnoredValueChanged()
{
bool isIgnored = accessibilityIsIgnored();
- if (cachedIsIgnoredValue() != isIgnored) {
+ if (lastKnownIsIgnoredValue() != isIgnored) {
axObjectCache()->childrenChanged(parentObject());
- setCachedIsIgnoredValue(isIgnored);
+ setLastKnownIsIgnoredValue(isIgnored);
}
}
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (142367 => 142368)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.h 2013-02-09 18:34:02 UTC (rev 142367)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h 2013-02-09 18:35:47 UTC (rev 142368)
@@ -748,8 +748,8 @@
// Scroll this object to a given point in global coordinates of the top-level window.
virtual void scrollToGlobalPoint(const IntPoint&) const;
- bool cachedIsIgnoredValue();
- void setCachedIsIgnoredValue(bool);
+ bool lastKnownIsIgnoredValue();
+ void setLastKnownIsIgnoredValue(bool);
// Fires a children changed notification on the parent if the isIgnored value changed.
void notifyIfIgnoredValueChanged();
@@ -832,7 +832,7 @@
AccessibilityChildrenVector m_children;
mutable bool m_haveChildren;
AccessibilityRole m_role;
- AccessibilityObjectInclusion m_cachedIsIgnoredValue;
+ AccessibilityObjectInclusion m_lastKnownIsIgnoredValue;
// If this object itself scrolls, return its ScrollableArea.
virtual ScrollableArea* getScrollableAreaIfScrollable() const { return 0; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
