Title: [142645] trunk
- Revision
- 142645
- Author
- [email protected]
- Date
- 2013-02-12 11:13:56 -0800 (Tue, 12 Feb 2013)
Log Message
Background size width specified in viewport percentage units not working
https://bugs.webkit.org/show_bug.cgi?id=109536
Patch by Uday Kiran <[email protected]> on 2013-02-12
Reviewed by Antti Koivisto.
Source/WebCore:
Corrected the check for viewport percentage unit while calculating
background image width.
Test: fast/backgrounds/size/backgroundSize-viewportPercentage-width.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
LayoutTests:
Added a test for background image width specified in viewport percentage unit.
* fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html: Added.
* fast/backgrounds/size/backgroundSize-viewportPercentage-width.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (142644 => 142645)
--- trunk/LayoutTests/ChangeLog 2013-02-12 19:04:23 UTC (rev 142644)
+++ trunk/LayoutTests/ChangeLog 2013-02-12 19:13:56 UTC (rev 142645)
@@ -1,3 +1,15 @@
+2013-02-12 Uday Kiran <[email protected]>
+
+ Background size width specified in viewport percentage units not working
+ https://bugs.webkit.org/show_bug.cgi?id=109536
+
+ Reviewed by Antti Koivisto.
+
+ Added a test for background image width specified in viewport percentage unit.
+
+ * fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html: Added.
+ * fast/backgrounds/size/backgroundSize-viewportPercentage-width.html: Added.
+
2013-02-12 Pablo Flouret <[email protected]>
Handle error recovery in @supports
Added: trunk/LayoutTests/fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html (0 => 142645)
--- trunk/LayoutTests/fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html 2013-02-12 19:13:56 UTC (rev 142645)
@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html>
+<body>
+<div style="width: 50vw; height: 300px; background: url('resources/flower.jpg') top left / 50% 300px repeat-x"></div>
+<p><a href=""
+You should see image repeated twice horizontally.</p>
+</body>
+</html>
Added: trunk/LayoutTests/fast/backgrounds/size/backgroundSize-viewportPercentage-width.html (0 => 142645)
--- trunk/LayoutTests/fast/backgrounds/size/backgroundSize-viewportPercentage-width.html (rev 0)
+++ trunk/LayoutTests/fast/backgrounds/size/backgroundSize-viewportPercentage-width.html 2013-02-12 19:13:56 UTC (rev 142645)
@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html>
+<body>
+<div style="width: 50vw; height: 300px; background: url('resources/flower.jpg') top left / 25vw 300px repeat-x"></div>
+<p><a href=""
+You should see image repeated twice horizontally.</p>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (142644 => 142645)
--- trunk/Source/WebCore/ChangeLog 2013-02-12 19:04:23 UTC (rev 142644)
+++ trunk/Source/WebCore/ChangeLog 2013-02-12 19:13:56 UTC (rev 142645)
@@ -1,3 +1,18 @@
+2013-02-12 Uday Kiran <[email protected]>
+
+ Background size width specified in viewport percentage units not working
+ https://bugs.webkit.org/show_bug.cgi?id=109536
+
+ Reviewed by Antti Koivisto.
+
+ Corrected the check for viewport percentage unit while calculating
+ background image width.
+
+ Test: fast/backgrounds/size/backgroundSize-viewportPercentage-width.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::calculateFillTileSize):
+
2013-02-12 Abhishek Arya <[email protected]>
Heap-use-after-free in WebCore::DeleteButtonController::enable
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (142644 => 142645)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2013-02-12 19:04:23 UTC (rev 142644)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2013-02-12 19:13:56 UTC (rev 142645)
@@ -1022,7 +1022,7 @@
if (layerWidth.isFixed())
tileSize.setWidth(layerWidth.value());
- else if (layerWidth.isPercent() || layerHeight.isViewportPercentage())
+ else if (layerWidth.isPercent() || layerWidth.isViewportPercentage())
tileSize.setWidth(valueForLength(layerWidth, positioningAreaSize.width(), renderView));
if (layerHeight.isFixed())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
