Title: [142869] trunk/Source/WebCore
- Revision
- 142869
- Author
- apav...@chromium.org
- Date
- 2013-02-14 04:47:16 -0800 (Thu, 14 Feb 2013)
Log Message
Web Inspector: Consistently use SecurityOrigin::toRawString() for serialization across the backend code
https://bugs.webkit.org/show_bug.cgi?id=109801
Reviewed by Yury Semikhatsky.
No new tests, as existing tests cover the change.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (142868 => 142869)
--- trunk/Source/WebCore/ChangeLog 2013-02-14 12:35:09 UTC (rev 142868)
+++ trunk/Source/WebCore/ChangeLog 2013-02-14 12:47:16 UTC (rev 142869)
@@ -1,3 +1,21 @@
+2013-02-14 Alexander Pavlov <apav...@chromium.org>
+
+ Web Inspector: Consistently use SecurityOrigin::toRawString() for serialization across the backend code
+ https://bugs.webkit.org/show_bug.cgi?id=109801
+
+ Reviewed by Yury Semikhatsky.
+
+ No new tests, as existing tests cover the change.
+
+ * inspector/InspectorAgent.cpp:
+ (WebCore::InspectorAgent::didClearWindowObjectInWorld):
+ * inspector/InspectorIndexedDBAgent.cpp:
+ (WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
+ * inspector/InspectorPageAgent.cpp:
+ (WebCore::InspectorPageAgent::buildObjectForFrame):
+ * inspector/PageRuntimeAgent.cpp:
+ (WebCore::PageRuntimeAgent::notifyContextCreated):
+
2013-02-14 Sergio Villar Senin <svil...@igalia.com>
Add logging support to IndexedDB for non-Chromium platforms
Modified: trunk/Source/WebCore/inspector/InspectorAgent.cpp (142868 => 142869)
--- trunk/Source/WebCore/inspector/InspectorAgent.cpp 2013-02-14 12:35:09 UTC (rev 142868)
+++ trunk/Source/WebCore/inspector/InspectorAgent.cpp 2013-02-14 12:47:16 UTC (rev 142869)
@@ -86,7 +86,7 @@
if (m_injectedScriptForOrigin.isEmpty())
return;
- String origin = frame->document()->securityOrigin()->toString();
+ String origin = frame->document()->securityOrigin()->toRawString();
String script = m_injectedScriptForOrigin.get(origin);
if (!script.isEmpty())
m_injectedScriptManager->injectScript(script, mainWorldScriptState(frame));
Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (142868 => 142869)
--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2013-02-14 12:35:09 UTC (rev 142868)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2013-02-14 12:47:16 UTC (rev 142869)
@@ -658,7 +658,7 @@
requestCallback->sendFailure("Could not obtain database names.");
return;
}
- idbRequest->addEventListener(eventNames().successEvent, GetDatabaseNamesCallback::create(requestCallback, document->securityOrigin()->toString()), false);
+ idbRequest->addEventListener(eventNames().successEvent, GetDatabaseNamesCallback::create(requestCallback, document->securityOrigin()->toRawString()), false);
}
void InspectorIndexedDBAgent::requestDatabase(ErrorString* errorString, const String& frameId, const String& databaseName, PassRefPtr<RequestDatabaseCallback> requestCallback)
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (142868 => 142869)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2013-02-14 12:35:09 UTC (rev 142868)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2013-02-14 12:47:16 UTC (rev 142869)
@@ -1057,7 +1057,7 @@
frameObject->setName(name);
}
// FIXME: Make this field non-optional. https://bugs.webkit.org/show_bug.cgi?id=80857
- frameObject->setSecurityOrigin(frame->document()->securityOrigin()->toString());
+ frameObject->setSecurityOrigin(frame->document()->securityOrigin()->toRawString());
return frameObject;
}
Modified: trunk/Source/WebCore/inspector/PageRuntimeAgent.cpp (142868 => 142869)
--- trunk/Source/WebCore/inspector/PageRuntimeAgent.cpp 2013-02-14 12:35:09 UTC (rev 142868)
+++ trunk/Source/WebCore/inspector/PageRuntimeAgent.cpp 2013-02-14 12:47:16 UTC (rev 142869)
@@ -179,7 +179,7 @@
{
ASSERT(securityOrigin || isPageContext);
int executionContextId = injectedScriptManager()->injectedScriptIdFor(scriptState);
- String name = securityOrigin ? securityOrigin->toString() : "";
+ String name = securityOrigin ? securityOrigin->toRawString() : "";
m_frontend->executionContextCreated(ExecutionContextDescription::create()
.setId(executionContextId)
.setIsPageContext(isPageContext)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
