Title: [143105] trunk/Tools
Revision
143105
Author
[email protected]
Date
2013-02-16 10:08:47 -0800 (Sat, 16 Feb 2013)

Log Message

[chromium] destroy the TestPlugin when the destroy() method is invoked.
https://bugs.webkit.org/show_bug.cgi?id=110012

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::destroy):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (143104 => 143105)


--- trunk/Tools/ChangeLog	2013-02-16 17:09:01 UTC (rev 143104)
+++ trunk/Tools/ChangeLog	2013-02-16 18:08:47 UTC (rev 143105)
@@ -1,3 +1,13 @@
+2013-02-16  Jochen Eisinger  <[email protected]>
+
+        [chromium] destroy the TestPlugin when the destroy() method is invoked.
+        https://bugs.webkit.org/show_bug.cgi?id=110012
+
+        Reviewed by Adam Barth.
+
+        * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
+        (WebTestRunner::TestPlugin::destroy):
+
 2013-02-15  Adenilson Cavalcanti  <[email protected]>
 
         [WK2] Write a test to simulate crashed WebProcess followed by Window resize

Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp (143104 => 143105)


--- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp	2013-02-16 17:09:01 UTC (rev 143104)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp	2013-02-16 18:08:47 UTC (rev 143105)
@@ -139,9 +139,15 @@
     return WebPluginContainer::TouchEventRequestTypeNone;
 }
 
+void deferredDelete(void* context)
+{
+    TestPlugin* plugin = static_cast<TestPlugin*>(context);
+    delete plugin;
 }
 
+}
 
+
 TestPlugin::TestPlugin(WebFrame* frame, const WebPluginParams& params, WebTestDelegate* delegate)
     : m_frame(frame)
     , m_delegate(delegate)
@@ -231,6 +237,8 @@
 
     m_container = 0;
     m_frame = 0;
+
+    Platform::current()->callOnMainThread(deferredDelete, this);
 }
 
 void TestPlugin::updateGeometry(const WebRect& frameRect, const WebRect& clipRect, const WebVector<WebRect>& cutOutsRects, bool isVisible)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to