Title: [143194] trunk
- Revision
- 143194
- Author
- [email protected]
- Date
- 2013-02-18 04:11:58 -0800 (Mon, 18 Feb 2013)
Log Message
[EFL][WK2] compositing/layer-creation/fixed-position-out-of-view-scaled.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=110059
Patch by Huang Dongsung <[email protected]> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Remove the ASSERT check in TextureMapperLayer. This assertion seems
valid because CoordinatedGraphicsScene::adjustPositionForFixedLayers() calls
TextureMapperLayer::setScrollPositionDeltaIfNeeded() when the graphics
layer is a fixed position layer. However, the assertion can be failed
because it is possible that TextureMapperLayer is a non-fixed position
layer when the graphics layer that holds the TextureMapperLayer is a
fixed position layer. When CoordinatedGraphicsScene flushes,
TextureMapperLayer becomes a fixed position layer.
No new tests. No change in behavior.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
LayoutTests:
Unskip two tests on EFL port. Now those pass.
compositing/layer-creation/fixed-position-out-of-view-scaled.html
compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
* platform/efl-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (143193 => 143194)
--- trunk/LayoutTests/ChangeLog 2013-02-18 11:45:10 UTC (rev 143193)
+++ trunk/LayoutTests/ChangeLog 2013-02-18 12:11:58 UTC (rev 143194)
@@ -1,3 +1,16 @@
+2013-02-18 Huang Dongsung <[email protected]>
+
+ [EFL][WK2] compositing/layer-creation/fixed-position-out-of-view-scaled.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=110059
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Unskip two tests on EFL port. Now those pass.
+ compositing/layer-creation/fixed-position-out-of-view-scaled.html
+ compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
+
+ * platform/efl-wk2/TestExpectations:
+
2013-02-18 Christophe Dumez <[email protected]>
Unreviewed EFL gardening.
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (143193 => 143194)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-02-18 11:45:10 UTC (rev 143193)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-02-18 12:11:58 UTC (rev 143194)
@@ -78,10 +78,6 @@
webkit.org/b/109945 webgl/conformance/uniforms/uniform-default-values.html [ Crash ]
webkit.org/b/109945 webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html [ Crash ]
-# ASSERTION FAILED: m_fixedToViewport.
-webkit.org/b/110059 [ Debug ] compositing/layer-creation/fixed-position-out-of-view-scaled.html [ Crash Pass ]
-webkit.org/b/110059 [ Debug ] compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html [ Crash Pass ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# FLAKY TESTS
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Source/WebCore/ChangeLog (143193 => 143194)
--- trunk/Source/WebCore/ChangeLog 2013-02-18 11:45:10 UTC (rev 143193)
+++ trunk/Source/WebCore/ChangeLog 2013-02-18 12:11:58 UTC (rev 143194)
@@ -1,3 +1,24 @@
+2013-02-18 Huang Dongsung <[email protected]>
+
+ [EFL][WK2] compositing/layer-creation/fixed-position-out-of-view-scaled.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=110059
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Remove the ASSERT check in TextureMapperLayer. This assertion seems
+ valid because CoordinatedGraphicsScene::adjustPositionForFixedLayers() calls
+ TextureMapperLayer::setScrollPositionDeltaIfNeeded() when the graphics
+ layer is a fixed position layer. However, the assertion can be failed
+ because it is possible that TextureMapperLayer is a non-fixed position
+ layer when the graphics layer that holds the TextureMapperLayer is a
+ fixed position layer. When CoordinatedGraphicsScene flushes,
+ TextureMapperLayer becomes a fixed position layer.
+
+ No new tests. No change in behavior.
+
+ * platform/graphics/texmap/TextureMapperLayer.cpp:
+ (WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
+
2013-02-18 Grzegorz Czajkowski <[email protected]>
[WK2][EFL] Unified text checker implementation
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (143193 => 143194)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2013-02-18 11:45:10 UTC (rev 143193)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2013-02-18 12:11:58 UTC (rev 143194)
@@ -603,7 +603,6 @@
// in the web process. We add this delta to the position of fixed layers, to make
// sure that they do not move while scrolling. We need to reset this delta to fixed layers
// that have an ancestor which is also a fixed layer, because the delta will be added to the ancestor.
- ASSERT(m_fixedToViewport);
if (isAncestorFixedToViewport())
m_scrollPositionDelta = FloatSize();
else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
