Title: [143227] trunk/Source/WebCore
Revision
143227
Author
[email protected]
Date
2013-02-18 08:54:19 -0800 (Mon, 18 Feb 2013)

Log Message

Web Inspector: Disable hiding the debugger when it is below the source code
https://bugs.webkit.org/show_bug.cgi?id=110106

Patch by Vladislav Kaznacheev <[email protected]> on 2013-02-18
Reviewed by Pavel Feldman.

When the "Split horizontally" option is checked in the Sources panel the button responsible for the sidebar
visibility is hidden and the sidebar is force-shown. Also set the "Split sidebar" option default to true.

No new tests.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/scriptsPanel.css:
(.split-view-horizontal #scripts-debug-sidebar-resizer-widget):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (143226 => 143227)


--- trunk/Source/WebCore/ChangeLog	2013-02-18 16:49:46 UTC (rev 143226)
+++ trunk/Source/WebCore/ChangeLog	2013-02-18 16:54:19 UTC (rev 143227)
@@ -1,3 +1,20 @@
+2013-02-18  Vladislav Kaznacheev  <[email protected]>
+
+        Web Inspector: Disable hiding the debugger when it is below the source code
+        https://bugs.webkit.org/show_bug.cgi?id=110106
+
+        Reviewed by Pavel Feldman.
+
+        When the "Split horizontally" option is checked in the Sources panel the button responsible for the sidebar
+        visibility is hidden and the sidebar is force-shown. Also set the "Split sidebar" option default to true.
+
+        No new tests.
+
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel):
+        * inspector/front-end/scriptsPanel.css:
+        (.split-view-horizontal #scripts-debug-sidebar-resizer-widget):
+
 2013-02-18  Bear Travis  <[email protected]>
 
         [CSS Exclusions] Support outside-shape layout for shape-inside property

Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (143226 => 143227)


--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2013-02-18 16:49:46 UTC (rev 143226)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2013-02-18 16:54:19 UTC (rev 143227)
@@ -120,9 +120,6 @@
         this.sidebarPanes.workerList = new WebInspector.WorkersSidebarPane(WebInspector.workerManager);
     }
 
-    WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
-    this._dockSideChanged();
-
     this.sidebarPanes.callstack.registerShortcuts(this.registerShortcuts.bind(this));
     this.registerShortcuts(WebInspector.ScriptsPanelDescriptor.ShortcutKeys.EvaluateSelectionInConsole, this._evaluateSelectionInConsole.bind(this));
     this.registerShortcuts(WebInspector.ScriptsPanelDescriptor.ShortcutKeys.GoToMember, this._showOutlineDialog.bind(this));
@@ -152,6 +149,9 @@
 
     this._installDebuggerSidebarController();
 
+    WebInspector.dockController.addEventListener(WebInspector.DockController.Events.DockSideChanged, this._dockSideChanged.bind(this));
+    this._dockSideChanged();
+
     this._sourceFramesByUISourceCode = new Map();
     this._updateDebuggerButtons();
     this._pauseOnExceptionStateChanged();
@@ -1174,6 +1174,8 @@
 
             this.sidebarElement.appendChild(this.debugToolbar);
         } else {
+            this._showDebuggerSidebar();
+
             this.sidebarPaneView = new WebInspector.SplitView(true, this.name + "PanelSplitSidebarRatio", 0.5);
 
             var group1 = new WebInspector.SidebarPaneStack();

Modified: trunk/Source/WebCore/inspector/front-end/scriptsPanel.css (143226 => 143227)


--- trunk/Source/WebCore/inspector/front-end/scriptsPanel.css	2013-02-18 16:49:46 UTC (rev 143226)
+++ trunk/Source/WebCore/inspector/front-end/scriptsPanel.css	2013-02-18 16:54:19 UTC (rev 143227)
@@ -264,6 +264,11 @@
     border: none;
 }
 
+.split-view-horizontal button.status-bar-item.scripts-debugger-show-hide-button,
+.split-view-horizontal #scripts-debug-sidebar-resizer-widget {
+    display: none;
+}
+
 button.status-bar-item.scripts-debugger-show-hide-button:active {
     top: 1px;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to