Title: [143325] trunk/Source/WebCore
- Revision
- 143325
- Author
- [email protected]
- Date
- 2013-02-19 06:31:43 -0800 (Tue, 19 Feb 2013)
Log Message
Web Inspector: [Canvas] do not replace replay image with spinner icon
https://bugs.webkit.org/show_bug.cgi?id=110213
Reviewed by Pavel Feldman.
Otherwise it's visually hard to see changes in the replay image. Instead show a small spinner icon in the bottom right corner.
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
* inspector/front-end/canvasProfiler.css:
(#canvas-replay-image-container):
(.canvas-debug-info):
(.canvas-spinner-icon):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (143324 => 143325)
--- trunk/Source/WebCore/ChangeLog 2013-02-19 14:29:47 UTC (rev 143324)
+++ trunk/Source/WebCore/ChangeLog 2013-02-19 14:31:43 UTC (rev 143325)
@@ -1,5 +1,22 @@
2013-02-19 Andrey Adaikin <[email protected]>
+ Web Inspector: [Canvas] do not replace replay image with spinner icon
+ https://bugs.webkit.org/show_bug.cgi?id=110213
+
+ Reviewed by Pavel Feldman.
+
+ Otherwise it's visually hard to see changes in the replay image. Instead show a small spinner icon in the bottom right corner.
+
+ * inspector/front-end/CanvasProfileView.js:
+ (WebInspector.CanvasProfileView):
+ (WebInspector.CanvasProfileView.prototype._enableWaitIcon):
+ * inspector/front-end/canvasProfiler.css:
+ (#canvas-replay-image-container):
+ (.canvas-debug-info):
+ (.canvas-spinner-icon):
+
+2013-02-19 Andrey Adaikin <[email protected]>
+
Web Inspector: [Canvas] UI: tweak replay control buttons behavior
https://bugs.webkit.org/show_bug.cgi?id=110207
Modified: trunk/Source/WebCore/inspector/front-end/CanvasProfileView.js (143324 => 143325)
--- trunk/Source/WebCore/inspector/front-end/CanvasProfileView.js 2013-02-19 14:29:47 UTC (rev 143324)
+++ trunk/Source/WebCore/inspector/front-end/CanvasProfileView.js 2013-02-19 14:31:43 UTC (rev 143325)
@@ -47,7 +47,8 @@
var replayImageContainer = this._splitView.firstElement();
replayImageContainer.id = "canvas-replay-image-container";
this._replayImageElement = replayImageContainer.createChild("image", "canvas-replay-image");
- this._debugInfoElement = replayImageContainer.createChild("div");
+ this._debugInfoElement = replayImageContainer.createChild("div", "canvas-debug-info hidden");
+ this._spinnerIcon = replayImageContainer.createChild("img", "canvas-spinner-icon hidden");
var replayInfoContainer = this._splitView.secondElement();
var controlsContainer = replayInfoContainer.createChild("div", "status-bar");
@@ -238,23 +239,8 @@
*/
_enableWaitIcon: function(enable)
{
- function showWaitIcon()
- {
- this._replayImageElement.addStyleClass("wait");
- this._debugInfoElement.addStyleClass("hidden");
- delete this._showWaitIconTimer;
- }
-
- if (enable && this._replayImageElement.src && !this._showWaitIconTimer)
- this._showWaitIconTimer = setTimeout(showWaitIcon.bind(this), 250);
- else {
- if (this._showWaitIconTimer) {
- clearTimeout(this._showWaitIconTimer);
- delete this._showWaitIconTimer;
- }
- this._replayImageElement.enableStyleClass("wait", enable);
- this._debugInfoElement.enableStyleClass("hidden", enable);
- }
+ this._spinnerIcon.enableStyleClass("hidden", !enable);
+ this._debugInfoElement.enableStyleClass("hidden", enable);
},
_replayTraceLog: function()
Modified: trunk/Source/WebCore/inspector/front-end/canvasProfiler.css (143324 => 143325)
--- trunk/Source/WebCore/inspector/front-end/canvasProfiler.css 2013-02-19 14:29:47 UTC (rev 143324)
+++ trunk/Source/WebCore/inspector/front-end/canvasProfiler.css 2013-02-19 14:31:43 UTC (rev 143325)
@@ -41,7 +41,7 @@
text-align: center;
background-color: black;
overflow: hidden;
- padding: 5px;
+ padding: 5px 5px 10px 5px;
color: white;
}
@@ -55,13 +55,19 @@
display: block;
}
-.canvas-replay-image.wait {
+.canvas-debug-info {
+ position: absolute;
+ left: 0;
+ right: 0;
+ bottom: 6px;
+}
+
+.canvas-spinner-icon {
content: url(Images/spinnerActiveSelected.gif);
- zoom: inherit;
position: absolute;
- top: 50%;
- left: 50%;
- margin: -16px 0 0 -16px;
+ width: 16px;
+ right: 4px;
+ bottom: 4px;
}
.canvas-replay-log {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
