Title: [143387] trunk/Source/WebCore
- Revision
- 143387
- Author
- [email protected]
- Date
- 2013-02-19 15:01:20 -0800 (Tue, 19 Feb 2013)
Log Message
[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
https://bugs.webkit.org/show_bug.cgi?id=110254
Patch by Kentaro Hara <[email protected]> on 2013-02-19
Reviewed by Adam Barth.
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951
Currently ScriptRunner::runCompiledScript() calls
ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
hitting the ASSERT(). The ASSERT() does not make sense at all.
Instead, we should return an empty handle when OOM occurs.
No tests. The bug happens only when OOM occurs.
* bindings/v8/ScriptRunner.cpp:
(WebCore::ScriptRunner::runCompiledScript):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (143386 => 143387)
--- trunk/Source/WebCore/ChangeLog 2013-02-19 22:58:29 UTC (rev 143386)
+++ trunk/Source/WebCore/ChangeLog 2013-02-19 23:01:20 UTC (rev 143387)
@@ -1,3 +1,22 @@
+2013-02-19 Kentaro Hara <[email protected]>
+
+ [V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
+ https://bugs.webkit.org/show_bug.cgi?id=110254
+
+ Reviewed by Adam Barth.
+
+ Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951
+
+ Currently ScriptRunner::runCompiledScript() calls
+ ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
+ hitting the ASSERT(). The ASSERT() does not make sense at all.
+ Instead, we should return an empty handle when OOM occurs.
+
+ No tests. The bug happens only when OOM occurs.
+
+ * bindings/v8/ScriptRunner.cpp:
+ (WebCore::ScriptRunner::runCompiledScript):
+
2013-02-19 Elliott Sprehn <[email protected]>
Support both MutationObserver and WebKitMutationObserver
Modified: trunk/Source/WebCore/bindings/v8/ScriptRunner.cpp (143386 => 143387)
--- trunk/Source/WebCore/bindings/v8/ScriptRunner.cpp 2013-02-19 22:58:29 UTC (rev 143386)
+++ trunk/Source/WebCore/bindings/v8/ScriptRunner.cpp 2013-02-19 23:01:20 UTC (rev 143387)
@@ -43,7 +43,7 @@
return handleMaxRecursionDepthExceeded();
if (handleOutOfMemory())
- ASSERT(script.IsEmpty());
+ return v8::Local<v8::Value>();
// Run the script and keep track of the current recursion depth.
v8::Local<v8::Value> result;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
