Title: [143629] trunk/Source/WebKit/blackberry
- Revision
- 143629
- Author
- commit-qu...@webkit.org
- Date
- 2013-02-21 11:09:07 -0800 (Thu, 21 Feb 2013)
Log Message
[BlackBerry] WebPagePrivate::load should not check new window policy
https://bugs.webkit.org/show_bug.cgi?id=110403
Patch by Andrew Lo <a...@rim.com> on 2013-02-21
Reviewed by Rob Buis.
Based on my understanding of changeset 135952, we should
not check the new window policy in WebPagePrivate::load.
None of the other ports seem to do this, except for plugins.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (143628 => 143629)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-02-21 18:51:20 UTC (rev 143628)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-02-21 19:09:07 UTC (rev 143629)
@@ -705,10 +705,7 @@
request.setSuggestedSaveName(suggestedSaveName);
- FrameLoadRequest frameRequest(m_mainFrame, request);
- frameRequest.setFrameName("");
- frameRequest.setShouldCheckNewWindowPolicy(true);
- m_mainFrame->loader()->load(frameRequest);
+ m_mainFrame->loader()->load(FrameLoadRequest(m_mainFrame, request));
}
void WebPage::load(const BlackBerry::Platform::String& url, const BlackBerry::Platform::String& networkToken, bool isInitial)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (143628 => 143629)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-02-21 18:51:20 UTC (rev 143628)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-02-21 19:09:07 UTC (rev 143629)
@@ -1,3 +1,18 @@
+2013-02-21 Andrew Lo <a...@rim.com>
+
+ [BlackBerry] WebPagePrivate::load should not check new window policy
+ https://bugs.webkit.org/show_bug.cgi?id=110403
+
+ Reviewed by Rob Buis.
+
+ Based on my understanding of changeset 135952, we should
+ not check the new window policy in WebPagePrivate::load.
+
+ None of the other ports seem to do this, except for plugins.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::load):
+
2013-02-21 Alberto Garcia <albgar...@rim.com>
[BlackBerry] BackingStore: replace instrument{Begin,Cancel}Frame with did{Begin,Cancel}Frame
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
