Modified: trunk/Source/WebCore/ChangeLog (143635 => 143636)
--- trunk/Source/WebCore/ChangeLog 2013-02-21 19:39:58 UTC (rev 143635)
+++ trunk/Source/WebCore/ChangeLog 2013-02-21 19:56:03 UTC (rev 143636)
@@ -1,3 +1,21 @@
+2013-02-21 Kentaro Hara <[email protected]>
+
+ [V8] Rename add{Node,Object}ToGroup() to add{Node,Object}WrapperToGroup()
+ https://bugs.webkit.org/show_bug.cgi?id=110404
+
+ Reviewed by Adam Barth.
+
+ The current function name is confusing
+ (See discussion in bug 110396). We should rename the functions
+ so that it becomes clear that "Node"/"Object" refers to a type
+ of a wrapper in the second argument.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/V8GCController.cpp:
+ (WebCore::WrapperGrouper::addObjectWrapperToGroup):
+ (WebCore::WrapperGrouper::addNodeWrapperToGroup):
+
2013-02-21 Vivek Galatage <[email protected]>
[JS Binding] ScriptObject default constructor should initialize the Script State to 0
Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (143635 => 143636)
--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2013-02-21 19:39:58 UTC (rev 143635)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2013-02-21 19:56:03 UTC (rev 143636)
@@ -90,12 +90,12 @@
m_liveObjects.append(V8PerIsolateData::current()->ensureLiveRoot());
}
- void addObjectToGroup(void* root, v8::Persistent<v8::Value> wrapper)
+ void addObjectWrapperToGroup(void* root, v8::Persistent<v8::Value> wrapper)
{
m_connections.append(ImplicitConnection(root, wrapper));
}
- void addNodeToGroup(Node* root, v8::Persistent<v8::Value> wrapper)
+ void addNodeWrapperToGroup(Node* root, v8::Persistent<v8::Value> wrapper)
{
m_connections.append(ImplicitConnection(root, wrapper));
}
@@ -311,7 +311,7 @@
MutationObserver* observer = static_cast<MutationObserver*>(object);
HashSet<Node*> observedNodes = observer->getObservedNodes();
for (HashSet<Node*>::iterator it = observedNodes.begin(); it != observedNodes.end(); ++it)
- m_grouper.addObjectToGroup(V8GCController::opaqueRootForGC(*it, m_isolate), wrapper);
+ m_grouper.addObjectWrapperToGroup(V8GCController::opaqueRootForGC(*it, m_isolate), wrapper);
} else {
ActiveDOMObject* activeDOMObject = type->toActiveDOMObject(wrapper);
if (activeDOMObject && activeDOMObject->hasPendingActivity())
@@ -328,9 +328,9 @@
if (node->hasEventListeners())
addImplicitReferencesForNodeWithEventListeners(node, wrapper);
- m_grouper.addNodeToGroup(V8GCController::opaqueRootForGC(node, m_isolate), wrapper);
+ m_grouper.addNodeWrapperToGroup(V8GCController::opaqueRootForGC(node, m_isolate), wrapper);
} else if (classId == v8DOMObjectClassId) {
- m_grouper.addObjectToGroup(type->opaqueRootForGC(object, wrapper, m_isolate), wrapper);
+ m_grouper.addObjectWrapperToGroup(type->opaqueRootForGC(object, wrapper, m_isolate), wrapper);
} else {
ASSERT_NOT_REACHED();
}
