Title: [143809] trunk/Source/WebCore
Revision
143809
Author
[email protected]
Date
2013-02-22 15:21:16 -0800 (Fri, 22 Feb 2013)

Log Message

Fix the overlay play button position on android
https://bugs.webkit.org/show_bug.cgi?id=110638

Patch by Min Qin <[email protected]> on 2013-02-22
Reviewed by Ojan Vafai.

Because we are using flex box, specifying the height is not necessary.
Setting height to 100% will make the enclosure go outside the control panel.
There are no media layout test expecations for android, will do that in another patch.

* css/mediaControlsChromiumAndroid.css:
(video::-webkit-media-controls-overlay-enclosure):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (143808 => 143809)


--- trunk/Source/WebCore/ChangeLog	2013-02-22 23:20:22 UTC (rev 143808)
+++ trunk/Source/WebCore/ChangeLog	2013-02-22 23:21:16 UTC (rev 143809)
@@ -1,3 +1,17 @@
+2013-02-22  Min Qin  <[email protected]>
+
+        Fix the overlay play button position on android
+        https://bugs.webkit.org/show_bug.cgi?id=110638
+
+        Reviewed by Ojan Vafai.
+
+        Because we are using flex box, specifying the height is not necessary.
+        Setting height to 100% will make the enclosure go outside the control panel.
+        There are no media layout test expecations for android, will do that in another patch.
+
+        * css/mediaControlsChromiumAndroid.css:
+        (video::-webkit-media-controls-overlay-enclosure):
+
 2013-02-22  Kentaro Hara  <[email protected]>
 
         Unreviewed build fix. Added missing #if PLATFORM(CHROMIUM).

Modified: trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css (143808 => 143809)


--- trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css	2013-02-22 23:20:22 UTC (rev 143808)
+++ trunk/Source/WebCore/css/mediaControlsChromiumAndroid.css	2013-02-22 23:21:16 UTC (rev 143809)
@@ -86,7 +86,6 @@
     -webkit-align-items: center;
     -webkit-flex: 1 1;
     width: 100%;
-    height: 100%;
     max-width: 800px;
     text-indent: 0;
     box-sizing: border-box;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to