Title: [143825] trunk/Source/WebCore
- Revision
- 143825
- Author
- [email protected]
- Date
- 2013-02-22 18:13:46 -0800 (Fri, 22 Feb 2013)
Log Message
RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>
Reviewed by Sam Weinig.
FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (143824 => 143825)
--- trunk/Source/WebCore/ChangeLog 2013-02-23 02:09:56 UTC (rev 143824)
+++ trunk/Source/WebCore/ChangeLog 2013-02-23 02:13:46 UTC (rev 143825)
@@ -1,3 +1,19 @@
+2013-02-22 Beth Dakin <[email protected]>
+
+ RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
+ https://bugs.webkit.org/show_bug.cgi?id=110673
+ -and corresponding-
+ <rdar://problem/13258596>
+
+ Reviewed by Sam Weinig.
+
+ FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
+ have overflow on the body. We can easily address this by calling it at the
+ end of RenderLayer::scrollTo().
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::scrollTo):
+
2013-02-22 Ryosuke Niwa <[email protected]>
WebKit can erroneously strip font-size CSS property from font element with size attribute
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (143824 => 143825)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2013-02-23 02:09:56 UTC (rev 143824)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2013-02-23 02:13:46 UTC (rev 143825)
@@ -60,6 +60,7 @@
#include "FloatRect.h"
#include "FocusController.h"
#include "Frame.h"
+#include "FrameLoaderClient.h"
#include "FrameSelection.h"
#include "FrameTree.h"
#include "FrameView.h"
@@ -2165,6 +2166,7 @@
renderer()->node()->document()->eventQueue()->enqueueOrDispatchScrollEvent(renderer()->node(), DocumentEventQueue::ScrollEventElementTarget);
InspectorInstrumentation::didScrollLayer(frame);
+ frame->loader()->client()->didChangeScrollOffset();
}
static inline bool frameElementAndViewPermitScroll(HTMLFrameElement* frameElement, FrameView* frameView)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
