- Revision
- 143851
- Author
- [email protected]
- Date
- 2013-02-23 14:37:30 -0800 (Sat, 23 Feb 2013)
Log Message
[V8] Rename constructorCallbackCustom() to constructorCustom()
https://bugs.webkit.org/show_bug.cgi?id=110671
Reviewed by Adam Barth.
his is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings.
See https://bugs.webkit.org/show_bug.cgi?id=110667#c0
In the new world, "Callback" is used to indicate that it
is a function called back by V8. Currently "Callback" is
used for both V8 callbacks, DOM methods and DOM constructors.
This patch fixes the inconsistency.
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateCustomConstructorCallback):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCustom):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCustom):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCustom):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCustom):
* bindings/v8/custom/V8MessageChannelCustom.cpp:
(WebCore::V8MessageChannel::constructorCustom):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCustom):
* bindings/v8/custom/V8WebKitPointCustom.cpp:
(WebCore::V8WebKitPoint::constructorCustom):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCustom):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (143850 => 143851)
--- trunk/Source/WebCore/ChangeLog 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/ChangeLog 2013-02-23 22:37:30 UTC (rev 143851)
@@ -1,5 +1,45 @@
2013-02-23 Kentaro Hara <[email protected]>
+ [V8] Rename constructorCallbackCustom() to constructorCustom()
+ https://bugs.webkit.org/show_bug.cgi?id=110671
+
+ Reviewed by Adam Barth.
+
+ his is one of steps to insert TRACE_EVENT_STATE() macros
+ into DOM bindings.
+ See https://bugs.webkit.org/show_bug.cgi?id=110667#c0
+
+ In the new world, "Callback" is used to indicate that it
+ is a function called back by V8. Currently "Callback" is
+ used for both V8 callbacks, DOM methods and DOM constructors.
+ This patch fixes the inconsistency.
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ (GenerateCustomConstructorCallback):
+ * bindings/v8/custom/V8ArrayBufferCustom.cpp:
+ (WebCore::V8ArrayBuffer::constructorCustom):
+ * bindings/v8/custom/V8AudioContextCustom.cpp:
+ (WebCore::V8AudioContext::constructorCustom):
+ * bindings/v8/custom/V8BlobCustom.cpp:
+ (WebCore::V8Blob::constructorCustom):
+ * bindings/v8/custom/V8DOMFormDataCustom.cpp:
+ (WebCore::V8DOMFormData::constructorCustom):
+ * bindings/v8/custom/V8DataViewCustom.cpp:
+ (WebCore::V8DataView::constructorCustom):
+ * bindings/v8/custom/V8MessageChannelCustom.cpp:
+ (WebCore::V8MessageChannel::constructorCustom):
+ * bindings/v8/custom/V8MutationObserverCustom.cpp:
+ (WebCore::V8MutationObserver::constructorCustom):
+ * bindings/v8/custom/V8WebKitPointCustom.cpp:
+ (WebCore::V8WebKitPoint::constructorCustom):
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+ (WebCore::V8XMLHttpRequest::constructorCustom):
+
+2013-02-23 Kentaro Hara <[email protected]>
+
[V8] Rename xxxCallback() to xxxMethod(), and xxxCallbackCustom() to xxxMethodCustom()
https://bugs.webkit.org/show_bug.cgi?id=110669
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (143850 => 143851)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-23 22:37:30 UTC (rev 143851)
@@ -413,7 +413,7 @@
}
if (HasCustomConstructor($interface)) {
push(@headerContent, <<END);
- static v8::Handle<v8::Value> constructorCallbackCustom(const v8::Arguments&);
+ static v8::Handle<v8::Value> constructorCustom(const v8::Arguments&);
END
}
@@ -1990,7 +1990,7 @@
push(@implContent, GenerateConstructorHeader());
push(@implContent, <<END);
- return V8${interfaceName}::constructorCallbackCustom(args);
+ return V8${interfaceName}::constructorCustom(args);
}
END
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -47,7 +47,7 @@
}
-v8::Handle<v8::Value> V8ArrayBuffer::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8ArrayBuffer::constructorCustom(const v8::Arguments& args)
{
// If we return a previously constructed ArrayBuffer,
// e.g. from the call to ArrayBufferView.buffer, this code is called
Modified: trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -41,7 +41,7 @@
namespace WebCore {
-v8::Handle<v8::Value> V8AudioContext::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8AudioContext::constructorCustom(const v8::Arguments& args)
{
Document* document = currentDocument(BindingState::instance());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -51,7 +51,7 @@
return V8Blob::createWrapper(impl, creationContext, isolate);
}
-v8::Handle<v8::Value> V8Blob::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8Blob::constructorCustom(const v8::Arguments& args)
{
ScriptExecutionContext* context = getScriptExecutionContext();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -39,7 +39,7 @@
namespace WebCore {
-v8::Handle<v8::Value> V8DOMFormData::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8DOMFormData::constructorCustom(const v8::Arguments& args)
{
HTMLFormElement* form = 0;
if (args.Length() > 0 && V8HTMLFormElement::HasInstance(args[0], args.GetIsolate()))
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -32,7 +32,7 @@
namespace WebCore {
-v8::Handle<v8::Value> V8DataView::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8DataView::constructorCustom(const v8::Arguments& args)
{
if (!args.Length()) {
// see constructWebGLArray -- we don't seem to be able to distingish between
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -43,7 +43,7 @@
namespace WebCore {
-v8::Handle<v8::Value> V8MessageChannel::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8MessageChannel::constructorCustom(const v8::Arguments& args)
{
ScriptExecutionContext* context = getScriptExecutionContext();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -41,7 +41,7 @@
namespace WebCore {
-v8::Handle<v8::Value> V8MutationObserver::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8MutationObserver::constructorCustom(const v8::Arguments& args)
{
if (args.Length() < 1)
return throwNotEnoughArgumentsError(args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -39,7 +39,7 @@
namespace WebCore {
-v8::Handle<v8::Value> V8WebKitPoint::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8WebKitPoint::constructorCustom(const v8::Arguments& args)
{
float x = 0;
float y = 0;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp (143850 => 143851)
--- trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp 2013-02-23 22:23:22 UTC (rev 143850)
+++ trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp 2013-02-23 22:37:30 UTC (rev 143851)
@@ -48,7 +48,7 @@
namespace WebCore {
-v8::Handle<v8::Value> V8XMLHttpRequest::constructorCallbackCustom(const v8::Arguments& args)
+v8::Handle<v8::Value> V8XMLHttpRequest::constructorCustom(const v8::Arguments& args)
{
ScriptExecutionContext* context = getScriptExecutionContext();
