Title: [143910] trunk/Tools
- Revision
- 143910
- Author
- [email protected]
- Date
- 2013-02-25 05:16:00 -0800 (Mon, 25 Feb 2013)
Log Message
Make ScriptError not crash when args is a tuple
https://bugs.webkit.org/show_bug.cgi?id=110747
Reviewed by Jochen Eisinger.
I'm trying to understand the error on
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
better. I'll likely have to revert the ninja switch on windows, but
having error reporting code that doesn't itself crash sounds like a
good thing to have anyways.
The problem is that '%s' % (1, 2) errors out, and args is sometimes a
tuple not a list.
* Scripts/run-chromium-webkit-unit-tests:
* Scripts/webkitpy/common/system/executive.py:
(ScriptError.__init__):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (143909 => 143910)
--- trunk/Tools/ChangeLog 2013-02-25 13:13:43 UTC (rev 143909)
+++ trunk/Tools/ChangeLog 2013-02-25 13:16:00 UTC (rev 143910)
@@ -1,3 +1,23 @@
+2013-02-25 Nico Weber <[email protected]>
+
+ Make ScriptError not crash when args is a tuple
+ https://bugs.webkit.org/show_bug.cgi?id=110747
+
+ Reviewed by Jochen Eisinger.
+
+ I'm trying to understand the error on
+ http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
+ better. I'll likely have to revert the ninja switch on windows, but
+ having error reporting code that doesn't itself crash sounds like a
+ good thing to have anyways.
+
+ The problem is that '%s' % (1, 2) errors out, and args is sometimes a
+ tuple not a list.
+
+ * Scripts/run-chromium-webkit-unit-tests:
+ * Scripts/webkitpy/common/system/executive.py:
+ (ScriptError.__init__):
+
2013-02-25 Laszlo Gombos <[email protected]>
[EFL] Align feature defaults
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (143909 => 143910)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2013-02-25 13:13:43 UTC (rev 143909)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2013-02-25 13:16:00 UTC (rev 143910)
@@ -53,7 +53,7 @@
output=None,
cwd=None):
if not message:
- message = 'Failed to run "%s"' % script_args
+ message = 'Failed to run "%s"' % repr(script_args)
if exit_code:
message += " exit_code: %d" % exit_code
if cwd:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
