Title: [144036] trunk/Source/WebCore
- Revision
- 144036
- Author
- [email protected]
- Date
- 2013-02-26 03:41:23 -0800 (Tue, 26 Feb 2013)
Log Message
XSSAuditor: Don't rely on implicit casting when copying the document's KURL to String.
https://bugs.webkit.org/show_bug.cgi?id=110859
Reviewed by Jochen Eisinger.
XSSAuditor::init should explicitly make a thread-safe copy of the
document's URL as a String rather than relying on implicit casting from
a copy of the KURL.
This shouldn't change any visible behavior; all existing XSSAuditor
tests should continue to pass. They'll now just be a bit more smug while
doing so.
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144035 => 144036)
--- trunk/Source/WebCore/ChangeLog 2013-02-26 11:31:02 UTC (rev 144035)
+++ trunk/Source/WebCore/ChangeLog 2013-02-26 11:41:23 UTC (rev 144036)
@@ -1,3 +1,21 @@
+2013-02-26 Mike West <[email protected]>
+
+ XSSAuditor: Don't rely on implicit casting when copying the document's KURL to String.
+ https://bugs.webkit.org/show_bug.cgi?id=110859
+
+ Reviewed by Jochen Eisinger.
+
+ XSSAuditor::init should explicitly make a thread-safe copy of the
+ document's URL as a String rather than relying on implicit casting from
+ a copy of the KURL.
+
+ This shouldn't change any visible behavior; all existing XSSAuditor
+ tests should continue to pass. They'll now just be a bit more smug while
+ doing so.
+
+ * html/parser/XSSAuditor.cpp:
+ (WebCore::XSSAuditor::init):
+
2013-02-26 Takashi Sakamoto <[email protected]>
Shadow DOM styles appear to be over-eagerly shared
Modified: trunk/Source/WebCore/html/parser/XSSAuditor.cpp (144035 => 144036)
--- trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2013-02-26 11:31:02 UTC (rev 144035)
+++ trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2013-02-26 11:41:23 UTC (rev 144036)
@@ -285,7 +285,7 @@
if (!m_reportURL.isEmpty()) {
// May need these for reporting later on.
- m_originalURL = m_documentURL.copy();
+ m_originalURL = m_documentURL.string().isolatedCopy();
m_originalHTTPBody = httpBodyAsString;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
