Title: [144068] trunk/Source/WebCore
Revision
144068
Author
[email protected]
Date
2013-02-26 09:50:46 -0800 (Tue, 26 Feb 2013)

Log Message

REGRESSION(r143986): fast/files/revoke-blob-url.html asserts
https://bugs.webkit.org/show_bug.cgi?id=110885
        
Reviewed by Alexey Proskuryakov.

The ResourceRequest string constructor assumes that the string is a valid URL. Use KURL constructor instead.

* html/DOMURL.cpp:
(WebCore::DOMURL::revokeObjectURL):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (144067 => 144068)


--- trunk/Source/WebCore/ChangeLog	2013-02-26 17:16:35 UTC (rev 144067)
+++ trunk/Source/WebCore/ChangeLog	2013-02-26 17:50:46 UTC (rev 144068)
@@ -1,3 +1,15 @@
+2013-02-26  Antti Koivisto  <[email protected]>
+
+        REGRESSION(r143986): fast/files/revoke-blob-url.html asserts
+        https://bugs.webkit.org/show_bug.cgi?id=110885
+        
+        Reviewed by Alexey Proskuryakov.
+
+        The ResourceRequest string constructor assumes that the string is a valid URL. Use KURL constructor instead.
+
+        * html/DOMURL.cpp:
+        (WebCore::DOMURL::revokeObjectURL):
+
 2013-02-26  Dean Jackson  <[email protected]>
 
         Draw intermediate snapshots if possible

Modified: trunk/Source/WebCore/html/DOMURL.cpp (144067 => 144068)


--- trunk/Source/WebCore/html/DOMURL.cpp	2013-02-26 17:16:35 UTC (rev 144067)
+++ trunk/Source/WebCore/html/DOMURL.cpp	2013-02-26 17:50:46 UTC (rev 144068)
@@ -114,13 +114,13 @@
     if (!scriptExecutionContext)
         return;
 
-    ResourceRequest request(urlString);
+    KURL url(KURL(), urlString);
+    ResourceRequest request(url);
 #if ENABLE(CACHE_PARTITIONING)
     request.setCachePartition(scriptExecutionContext->topOrigin()->cachePartition());
 #endif
     MemoryCache::removeRequestFromCache(scriptExecutionContext, request);
 
-    KURL url(KURL(), urlString);
     HashSet<String>& blobURLs = scriptExecutionContext->publicURLManager().blobURLs();
     if (blobURLs.contains(url.string())) {
         ThreadableBlobRegistry::unregisterBlobURL(url);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to