Title: [144085] trunk/Source/WebCore
- Revision
- 144085
- Author
- [email protected]
- Date
- 2013-02-26 12:13:36 -0800 (Tue, 26 Feb 2013)
Log Message
[BlackBerry] Animated images not animating on accelerated compositing layers
https://bugs.webkit.org/show_bug.cgi?id=110886
Patch by Andrew Lo <[email protected]> on 2013-02-26
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
Internal PR 299598.
Animated images on AC layers call GraphicsLayer::setContentsToImage
on each frame with the same Image.
We need to set needs display in that case so that the frames are
displayed.
No new tests are needed since there is no new functionality.
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::setContents):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144084 => 144085)
--- trunk/Source/WebCore/ChangeLog 2013-02-26 19:43:39 UTC (rev 144084)
+++ trunk/Source/WebCore/ChangeLog 2013-02-26 20:13:36 UTC (rev 144085)
@@ -1,3 +1,24 @@
+2013-02-26 Andrew Lo <[email protected]>
+
+ [BlackBerry] Animated images not animating on accelerated compositing layers
+ https://bugs.webkit.org/show_bug.cgi?id=110886
+
+ Reviewed by Rob Buis.
+
+ Internally reviewed by Arvid Nilsson.
+ Internal PR 299598.
+
+ Animated images on AC layers call GraphicsLayer::setContentsToImage
+ on each frame with the same Image.
+
+ We need to set needs display in that case so that the frames are
+ displayed.
+
+ No new tests are needed since there is no new functionality.
+
+ * platform/graphics/blackberry/LayerWebKitThread.cpp:
+ (WebCore::LayerWebKitThread::setContents):
+
2013-02-26 Sheriff Bot <[email protected]>
Unreviewed, rolling out r144065.
Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.cpp (144084 => 144085)
--- trunk/Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.cpp 2013-02-26 19:43:39 UTC (rev 144084)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.cpp 2013-02-26 20:13:36 UTC (rev 144085)
@@ -171,8 +171,12 @@
void LayerWebKitThread::setContents(Image* contents)
{
// Check if the image has changed.
- if (m_contents == contents)
+ if (m_contents == contents) {
+ // Set needs display for animated images.
+ if (contents)
+ setNeedsDisplay();
return;
+ }
m_contents = contents;
setNeedsTexture(m_isDrawable && (this->contents() || drawsContent() || pluginView()));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
