Title: [144112] trunk/Source/WebKit/chromium
Revision
144112
Author
[email protected]
Date
2013-02-26 14:49:36 -0800 (Tue, 26 Feb 2013)

Log Message

[chromium] Remove unused WebWidget::instrument calls
https://bugs.webkit.org/show_bug.cgi?id=110906

Patch by James Robinson <[email protected]> on 2013-02-26
Reviewed by Jochen Eisinger.

These calls are now routed through WebDevToolsAgent.

* public/WebWidget.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::willBeginFrame):
* src/WebViewImpl.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (144111 => 144112)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-26 22:40:55 UTC (rev 144111)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-26 22:49:36 UTC (rev 144112)
@@ -1,3 +1,17 @@
+2013-02-26  James Robinson  <[email protected]>
+
+        [chromium] Remove unused WebWidget::instrument calls
+        https://bugs.webkit.org/show_bug.cgi?id=110906
+
+        Reviewed by Jochen Eisinger.
+
+        These calls are now routed through WebDevToolsAgent.
+
+        * public/WebWidget.h:
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::willBeginFrame):
+        * src/WebViewImpl.h:
+
 2013-02-20  Alpha Lam  <[email protected]>
 
         GIFImageReader to read from source data directly

Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (144111 => 144112)


--- trunk/Source/WebKit/chromium/public/WebWidget.h	2013-02-26 22:40:55 UTC (rev 144111)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h	2013-02-26 22:49:36 UTC (rev 144112)
@@ -235,13 +235,6 @@
     // rect.)
     virtual void didChangeWindowResizerRect() { }
 
-    // Instrumentation method that marks beginning of frame update that includes
-    // things like animate()/layout()/paint()/composite().
-    virtual void instrumentBeginFrame() { }
-    // Cancels the effect of instrumentBeginFrame() in case there were no events
-    // following the call to instrumentBeginFrame().
-    virtual void instrumentCancelFrame() { }
-
     // The page background color. Can be used for filling in areas without
     // content.
     virtual WebColor backgroundColor() const { return 0xFFFFFFFF; /* SK_ColorWHITE */ }

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (144111 => 144112)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-26 22:40:55 UTC (rev 144111)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-26 22:49:36 UTC (rev 144112)
@@ -1808,18 +1808,6 @@
 #endif
 }
 
-void WebViewImpl::instrumentBeginFrame()
-{
-    if (m_devToolsAgent)
-        m_devToolsAgent->didBeginFrame();
-}
-
-void WebViewImpl::instrumentCancelFrame()
-{
-    if (m_devToolsAgent)
-        m_devToolsAgent->didCancelFrame();
-}
-
 #if ENABLE(BATTERY_STATUS)
 void WebViewImpl::updateBatteryStatus(const WebBatteryStatus& status)
 {
@@ -1845,7 +1833,6 @@
 
 void WebViewImpl::willBeginFrame()
 {
-    instrumentBeginFrame();
     m_client->willBeginCompositorFrame();
 }
 

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (144111 => 144112)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-02-26 22:40:55 UTC (rev 144111)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-02-26 22:49:36 UTC (rev 144112)
@@ -181,8 +181,6 @@
     virtual void didNotAcquirePointerLock();
     virtual void didLosePointerLock();
     virtual void didChangeWindowResizerRect();
-    virtual void instrumentBeginFrame();
-    virtual void instrumentCancelFrame();
 
     // WebView methods:
     virtual void initializeMainFrame(WebFrameClient*);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to