Title: [144120] trunk/Source
- Revision
- 144120
- Author
- [email protected]
- Date
- 2013-02-26 16:31:11 -0800 (Tue, 26 Feb 2013)
Log Message
[chromium] Remove unused WebLayerTreeViewClient calls
https://bugs.webkit.org/show_bug.cgi?id=110923
Reviewed by Adrienne Walker.
These notifications existed for instrumentation, but now the instrumentation routes
through WebDevToolsAgent.
Source/Platform:
* chromium/public/WebLayerTreeViewClient.h:
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
* tests/WebLayerTreeViewTestCommon.h:
Modified Paths
Diff
Modified: trunk/Source/Platform/ChangeLog (144119 => 144120)
--- trunk/Source/Platform/ChangeLog 2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/Platform/ChangeLog 2013-02-27 00:31:11 UTC (rev 144120)
@@ -1,3 +1,15 @@
+2013-02-26 James Robinson <[email protected]>
+
+ [chromium] Remove unused WebLayerTreeViewClient calls
+ https://bugs.webkit.org/show_bug.cgi?id=110923
+
+ Reviewed by Adrienne Walker.
+
+ These notifications existed for instrumentation, but now the instrumentation routes
+ through WebDevToolsAgent.
+
+ * chromium/public/WebLayerTreeViewClient.h:
+
2013-02-26 Dana Jansens <[email protected]>
Create the SharedGraphicsContext3D through its own method.
Modified: trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h (144119 => 144120)
--- trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h 2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h 2013-02-27 00:31:11 UTC (rev 144120)
@@ -69,24 +69,6 @@
virtual WebInputHandler* createInputHandler() { return 0; }
- // Indicates that a frame will be committed to the impl side of the compositor
- // for rendering.
- virtual void willCommit() { }
-
- // Indicates that a frame was committed to the impl side of the compositor
- // for rendering.
- //
- // FIXME: make this non-virtual when ui/compositor DEP is resolved.
- virtual void didCommit() { }
-
- // Indicates that a frame was committed to the impl side and drawing
- // commands for it were issued to the GPU.
- virtual void didCommitAndDrawFrame() = 0;
-
- // Indicates that a frame previously issued to the GPU has completed
- // rendering.
- virtual void didCompleteSwapBuffers() = 0;
-
// Schedules a compositing pass, meaning the client should call
// WebLayerTreeView::composite at a later time. This is only called if the
// compositor thread is disabled; when enabled, the compositor will
Modified: trunk/Source/WebKit/chromium/ChangeLog (144119 => 144120)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-02-27 00:31:11 UTC (rev 144120)
@@ -1,3 +1,17 @@
+2013-02-26 James Robinson <[email protected]>
+
+ [chromium] Remove unused WebLayerTreeViewClient calls
+ https://bugs.webkit.org/show_bug.cgi?id=110923
+
+ Reviewed by Adrienne Walker.
+
+ These notifications existed for instrumentation, but now the instrumentation routes
+ through WebDevToolsAgent.
+
+ * src/WebViewImpl.cpp:
+ * src/WebViewImpl.h:
+ * tests/WebLayerTreeViewTestCommon.h:
+
2013-02-26 Dirk Pranke <[email protected]>
Roll Chromium DEPS from r183905 -> r184646.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (144119 => 144120)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-02-27 00:31:11 UTC (rev 144120)
@@ -4250,32 +4250,6 @@
}
}
-void WebViewImpl::willCommit()
-{
- if (m_devToolsAgent)
- m_devToolsAgent->willComposite();
-}
-
-void WebViewImpl::didCommit()
-{
- if (m_client) {
- m_client->didCommitCompositorFrame();
- m_client->didBecomeReadyForAdditionalInput();
- }
-}
-
-void WebViewImpl::didCommitAndDrawFrame()
-{
- if (m_client)
- m_client->didCommitAndDrawCompositorFrame();
-}
-
-void WebViewImpl::didCompleteSwapBuffers()
-{
- if (m_client)
- m_client->didCompleteSwapBuffers();
-}
-
void WebViewImpl::didRecreateOutputSurface(bool success)
{
// Switch back to software rendering mode, if necessary
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (144119 => 144120)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2013-02-27 00:31:11 UTC (rev 144120)
@@ -322,10 +322,6 @@
virtual WebCompositorOutputSurface* createOutputSurface() OVERRIDE;
virtual void didRecreateOutputSurface(bool success) OVERRIDE;
virtual WebInputHandler* createInputHandler() OVERRIDE;
- virtual void willCommit();
- virtual void didCommit();
- virtual void didCommitAndDrawFrame();
- virtual void didCompleteSwapBuffers();
virtual void scheduleComposite();
// WebViewImpl
Modified: trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h (144119 => 144120)
--- trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h 2013-02-27 00:28:23 UTC (rev 144119)
+++ trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h 2013-02-27 00:31:11 UTC (rev 144120)
@@ -47,11 +47,6 @@
return Platform::current()->compositorSupport()->createOutputSurfaceFor3D(CompositorFakeWebGraphicsContext3D::create(WebGraphicsContext3D::Attributes()).leakPtr());
}
virtual void didRecreateOutputSurface(bool) OVERRIDE { }
-
- MOCK_METHOD0(willCommit, void());
- MOCK_METHOD0(didCommit, void());
- virtual void didCommitAndDrawFrame() OVERRIDE { }
- virtual void didCompleteSwapBuffers() OVERRIDE { }
};
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
