Title: [144175] trunk/LayoutTests
- Revision
- 144175
- Author
- [email protected]
- Date
- 2013-02-27 05:49:31 -0800 (Wed, 27 Feb 2013)
Log Message
[chromium] Adapt test expectations to V8 __proto__ changes.
https://bugs.webkit.org/show_bug.cgi?id=110887
Patch by Michael Starzinger <[email protected]> on 2013-02-27
Reviewed by Stephen Chenney.
ad window-custom-prototype) This is expected bahavior, consistent with
SpiderMonkey. The test expectation is broken. Assigning 'null' to
'__proto__' makes the accessor installed on Object.prototype disappear.
ad JSON-parse) The result of JSON.parse() doesn't match the result we
get when evaluating the same string through eval() as V8 still has
special handling of the __proto__ property for object literals.
ad cyclic-prototypes) Test fully matches the WebKit expectation now and
no longer fails. However the exception message has a slightly different
format and hence causes a text diff.
* platform/chromium/TestExpectations: Temporary mark tests failing.
* platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
* platform/chromium/fast/js/JSON-parse-expected.txt:
* platform/chromium/fast/js/cyclic-prototypes-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (144174 => 144175)
--- trunk/LayoutTests/ChangeLog 2013-02-27 13:34:06 UTC (rev 144174)
+++ trunk/LayoutTests/ChangeLog 2013-02-27 13:49:31 UTC (rev 144175)
@@ -1,3 +1,27 @@
+2013-02-27 Michael Starzinger <[email protected]>
+
+ [chromium] Adapt test expectations to V8 __proto__ changes.
+ https://bugs.webkit.org/show_bug.cgi?id=110887
+
+ Reviewed by Stephen Chenney.
+
+ ad window-custom-prototype) This is expected bahavior, consistent with
+ SpiderMonkey. The test expectation is broken. Assigning 'null' to
+ '__proto__' makes the accessor installed on Object.prototype disappear.
+
+ ad JSON-parse) The result of JSON.parse() doesn't match the result we
+ get when evaluating the same string through eval() as V8 still has
+ special handling of the __proto__ property for object literals.
+
+ ad cyclic-prototypes) Test fully matches the WebKit expectation now and
+ no longer fails. However the exception message has a slightly different
+ format and hence causes a text diff.
+
+ * platform/chromium/TestExpectations: Temporary mark tests failing.
+ * platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
+ * platform/chromium/fast/js/JSON-parse-expected.txt:
+ * platform/chromium/fast/js/cyclic-prototypes-expected.txt:
+
2013-02-27 Vsevolod Vlasov <[email protected]>
Unreviewed chromium test expectations update.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144174 => 144175)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-27 13:34:06 UTC (rev 144174)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-27 13:49:31 UTC (rev 144175)
@@ -1581,6 +1581,11 @@
# Missing text -- slow font path unimplemented?
crbug.com/10344 [ Android Linux ] fast/text/should-use-atsui.html [ ImageOnlyFailure ]
+# Failure due to changes of V8's __proto__ property.
+webkit.org/b/110887 fast/dom/Window/window-custom-prototype.html [ Failure ]
+webkit.org/b/110887 fast/js/JSON-parse.html [ Failure ]
+webkit.org/b/110887 fast/js/cyclic-prototypes.html [ Failure ]
+
# Needs V8 fix. V8 bug: http://code.google.com/p/v8/issues/detail?id=1992
webkit.org/b/80335 fast/js/mozilla/strict/15.4.4.8.html [ Failure ]
webkit.org/b/80335 fast/js/mozilla/strict/15.4.4.9.html [ Failure ]
Modified: trunk/LayoutTests/platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt (144174 => 144175)
--- trunk/LayoutTests/platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt 2013-02-27 13:34:06 UTC (rev 144174)
+++ trunk/LayoutTests/platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt 2013-02-27 13:49:31 UTC (rev 144175)
@@ -14,7 +14,7 @@
PASS __proto__ = anotherObject; __proto__ is anotherObject
PASS __proto__ = originalWindowPrototype; __proto__ is originalWindowPrototype
PASS anotherObject.__proto__ = window; anotherObject.__proto__ is window
-PASS __proto__ = null; __proto__ is null
+FAIL __proto__ = null; __proto__ should be null. Threw exception ReferenceError: __proto__ is not defined
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/platform/chromium/fast/js/JSON-parse-expected.txt (144174 => 144175)
--- trunk/LayoutTests/platform/chromium/fast/js/JSON-parse-expected.txt 2013-02-27 13:34:06 UTC (rev 144174)
+++ trunk/LayoutTests/platform/chromium/fast/js/JSON-parse-expected.txt 2013-02-27 13:49:31 UTC (rev 144175)
@@ -69,7 +69,7 @@
function (jsonObject){
return jsonObject.parse('{"__proto__":5}');
}
-PASS JSON.stringify(tests[i](nativeJSON)) is JSON.stringify(tests[i](JSON))
+FAIL JSON.stringify(tests[i](nativeJSON)) should be {}. Was {"__proto__":5}.
function (jsonObject){
return jsonObject.parse('{"a":5,}');
}
@@ -446,7 +446,7 @@
function (jsonObject){
return jsonObject.parse('{"__proto__":{"a":5}}', log);
}
-PASS JSON.stringify(tests[i](nativeJSON)) is JSON.stringify(tests[i](JSON))
+FAIL JSON.stringify(tests[i](nativeJSON)) should be {"":{},"keyType":"string"}. Was {"":{"__proto__":{"keyType":"string"}},"keyType":"string"}.
function (jsonObject){
logOrderString = "";
return jsonObject.parse("true", logOrder);
Modified: trunk/LayoutTests/platform/chromium/fast/js/cyclic-prototypes-expected.txt (144174 => 144175)
--- trunk/LayoutTests/platform/chromium/fast/js/cyclic-prototypes-expected.txt 2013-02-27 13:34:06 UTC (rev 144174)
+++ trunk/LayoutTests/platform/chromium/fast/js/cyclic-prototypes-expected.txt 2013-02-27 13:49:31 UTC (rev 144175)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: line 16: Uncaught Error: Cyclic __proto__ value
This test makes sure we don't hang when setting cyclic prototype values: http://bugs.webkit.org/show_bug.cgi?id=6985
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -6,7 +5,9 @@
PASS o1.__proto__ = o3; threw exception Error: Cyclic __proto__ value.
PASS ({}).hasOwnProperty.call(o1, '__proto__') is false
-FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
+PASS ({}).hasOwnProperty.call(o1, '__proto__') is true
+PASS Object.getPrototypeOf(o1) is null
+PASS successfullyParsed is true
TEST COMPLETE
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
