Title: [144184] trunk
- Revision
- 144184
- Author
- [email protected]
- Date
- 2013-02-27 07:29:52 -0800 (Wed, 27 Feb 2013)
Log Message
REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
https://bugs.webkit.org/show_bug.cgi?id=110974
Reviewed by Kentaro Hara.
Source/WebCore:
Input elements with the multiple fields UI require flexible box
layout. We should use RenderFlexibleBox regardless of display
property values.
Tests: Update fast/forms/date/date-apparance-basic.html
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer):
Always use RenderFlexibleBox.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare createRenderer.
LayoutTests:
* fast/forms/date/date-appearance-basic-expected.txt:
* fast/forms/date/date-appearance-basic.html:
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (144183 => 144184)
--- trunk/LayoutTests/ChangeLog 2013-02-27 15:27:21 UTC (rev 144183)
+++ trunk/LayoutTests/ChangeLog 2013-02-27 15:29:52 UTC (rev 144184)
@@ -1,3 +1,15 @@
+2013-02-27 Kent Tamura <[email protected]>
+
+ REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
+ https://bugs.webkit.org/show_bug.cgi?id=110974
+
+ Reviewed by Kentaro Hara.
+
+ * fast/forms/date/date-appearance-basic-expected.txt:
+ * fast/forms/date/date-appearance-basic.html:
+ * platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
+ * platform/chromium/TestExpectations:
+
2013-02-27 Vivek Galatage <[email protected]>
Web Inspector: Refactor AuditsPanel with AuditController as newly introduced entity
Modified: trunk/LayoutTests/fast/forms/date/date-appearance-basic-expected.txt (144183 => 144184)
--- trunk/LayoutTests/fast/forms/date/date-appearance-basic-expected.txt 2013-02-27 15:27:21 UTC (rev 144183)
+++ trunk/LayoutTests/fast/forms/date/date-appearance-basic-expected.txt 2013-02-27 15:29:52 UTC (rev 144184)
@@ -10,3 +10,4 @@
font-size with fixed input width:
Fixed input height:
-webkit-appearance:none:
+display: none: inline: inline-block: block:
Modified: trunk/LayoutTests/fast/forms/date/date-appearance-basic.html (144183 => 144184)
--- trunk/LayoutTests/fast/forms/date/date-appearance-basic.html 2013-02-27 15:27:21 UTC (rev 144183)
+++ trunk/LayoutTests/fast/forms/date/date-appearance-basic.html 2013-02-27 15:29:52 UTC (rev 144184)
@@ -22,6 +22,10 @@
<li>Fixed input height: <input type="date" value="2012-10-05" style="height: 4em;">
<input type="date" value="2013-01-28" style="font-size: 20px; height: 10px;"></li>
<li>-webkit-appearance:none: <input type="date" value="2012-10-05" style="-webkit-appearance: none;"></li>
+ <li>display: none:<input type="date" style="display:none;">
+ inline:<input type="date" style="display:inline;">
+ inline-block:<input type="date" style="display:inline-block;">
+ block:<input type="date" style="display:block;">
</ul>
</body>
</html>
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144183 => 144184)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-27 15:27:21 UTC (rev 144183)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-27 15:29:52 UTC (rev 144184)
@@ -4448,6 +4448,7 @@
webkit.org/b/110654 [ Mac Win ] tables/mozilla/bugs/bug92647-2.html [ Failure ]
# New test
webkit.org/b/110654 [ Mac Win ] css3/flexbox/button.html [ Failure ]
+webkit.org/b/110974 fast/forms/date/date-appearance-basic.html [ ImageOnlyFailure ]
# This is possibly a bug in the version of fontconfig on Precise, not sure.
webkit.org/b/110915 [ Linux ] platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html [ Failure Pass ]
Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (144183 => 144184)
--- trunk/Source/WebCore/ChangeLog 2013-02-27 15:27:21 UTC (rev 144183)
+++ trunk/Source/WebCore/ChangeLog 2013-02-27 15:29:52 UTC (rev 144184)
@@ -1,3 +1,22 @@
+2013-02-27 Kent Tamura <[email protected]>
+
+ REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
+ https://bugs.webkit.org/show_bug.cgi?id=110974
+
+ Reviewed by Kentaro Hara.
+
+ Input elements with the multiple fields UI require flexible box
+ layout. We should use RenderFlexibleBox regardless of display
+ property values.
+
+ Tests: Update fast/forms/date/date-apparance-basic.html
+
+ * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
+ (WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer):
+ Always use RenderFlexibleBox.
+ * html/BaseMultipleFieldsDateAndTimeInputType.h:
+ (BaseMultipleFieldsDateAndTimeInputType): Declare createRenderer.
+
2013-02-27 Allan Sandfeld Jensen <[email protected]>
[TexMap] Flickering after transitions on Apple HTML5 demo
Modified: trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (144183 => 144184)
--- trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2013-02-27 15:27:21 UTC (rev 144183)
+++ trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2013-02-27 15:29:52 UTC (rev 144184)
@@ -47,6 +47,7 @@
#include "Page.h"
#include "PickerIndicatorElement.h"
#include "PlatformLocale.h"
+#include "RenderFlexibleBox.h"
#include "RenderTheme.h"
#include "ShadowRoot.h"
#include <wtf/DateMath.h>
@@ -189,6 +190,11 @@
m_dateTimeEditElement->blurByOwner();
}
+RenderObject* BaseMultipleFieldsDateAndTimeInputType::createRenderer(RenderArena* arena, RenderStyle*) const
+{
+ return new (arena) RenderFlexibleBox(element());
+}
+
void BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree()
{
ASSERT(element()->shadow());
Modified: trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h (144183 => 144184)
--- trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h 2013-02-27 15:27:21 UTC (rev 144183)
+++ trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h 2013-02-27 15:29:52 UTC (rev 144184)
@@ -78,6 +78,7 @@
// InputType functions
virtual String badInputText() const OVERRIDE;
virtual void blur() OVERRIDE FINAL;
+ virtual RenderObject* createRenderer(RenderArena*, RenderStyle*) const OVERRIDE;
virtual void createShadowSubtree() OVERRIDE FINAL;
virtual void destroyShadowSubtree() OVERRIDE FINAL;
virtual void disabledAttributeChanged() OVERRIDE FINAL;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
