Title: [144204] trunk/Source/WebCore
Revision
144204
Author
[email protected]
Date
2013-02-27 09:42:08 -0800 (Wed, 27 Feb 2013)

Log Message

[TexMap] REGRESSION(144183): It make negative delay tests fails
https://bugs.webkit.org/show_bug.cgi?id=110989

Reviewed by Noam Rosenthal.

Do not apply a negative offset to the animation starttime send to the GraphicLayerClient,
it needs the actual animation start not a virtual start.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (144203 => 144204)


--- trunk/Source/WebCore/ChangeLog	2013-02-27 17:35:04 UTC (rev 144203)
+++ trunk/Source/WebCore/ChangeLog	2013-02-27 17:42:08 UTC (rev 144204)
@@ -1,3 +1,16 @@
+2013-02-27  Allan Sandfeld Jensen  <[email protected]>
+
+        [TexMap] REGRESSION(144183): It make negative delay tests fails
+        https://bugs.webkit.org/show_bug.cgi?id=110989
+
+        Reviewed by Noam Rosenthal.
+
+        Do not apply a negative offset to the animation starttime send to the GraphicLayerClient,
+        it needs the actual animation start not a virtual start.
+
+        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+        (WebCore::GraphicsLayerTextureMapper::addAnimation):
+
 2013-02-27  Aaron Colwell  <[email protected]>
 
         Fix SourceBufferList so SourceBuffer.append() calls are always rejected after the MediaSource is closed.

Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (144203 => 144204)


--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp	2013-02-27 17:35:04 UTC (rev 144203)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp	2013-02-27 17:42:08 UTC (rev 144204)
@@ -613,8 +613,13 @@
     if (valueList.property() == AnimatedPropertyWebkitTransform)
         listsMatch = validateTransformOperations(valueList, hasBigRotation) >= 0;
 
-    m_animationStartTime = WTF::currentTime() - timeOffset;
-    m_animations.add(GraphicsLayerAnimation(keyframesName, valueList, boxSize, anim, m_animationStartTime, listsMatch));
+    const double currentTime = WTF::currentTime();
+    m_animations.add(GraphicsLayerAnimation(keyframesName, valueList, boxSize, anim, currentTime - timeOffset, listsMatch));
+    // m_animationStartTime is the time of the first real frame of animation, now or delayed by a negative offset.
+    if (timeOffset > 0)
+        m_animationStartTime = currentTime;
+    else
+        m_animationStartTime = currentTime - timeOffset;
     notifyChange(AnimationChange);
     notifyChange(AnimationStarted);
     return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to