Title: [144209] trunk/Source/WebKit/blackberry
- Revision
- 144209
- Author
- [email protected]
- Date
- 2013-02-27 10:19:04 -0800 (Wed, 27 Feb 2013)
Log Message
Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
https://bugs.webkit.org/show_bug.cgi?id=110905
Patch by John Griggs <[email protected]> on 2013-02-27
Reviewed by Yong Li.
Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (144208 => 144209)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-02-27 18:18:13 UTC (rev 144208)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-02-27 18:19:04 UTC (rev 144209)
@@ -1,3 +1,17 @@
+2013-02-27 John Griggs <[email protected]>
+
+ 2013-02-27 John Griggs <[email protected]>
+
+ Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
+ https://bugs.webkit.org/show_bug.cgi?id=110905
+
+ Reviewed by Yong Li.
+
+ Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.
+
+ * WebCoreSupport/ChromeClientBlackBerry.cpp:
+ (WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
+
2013-02-27 Sean Wang <[email protected]>
[BlackBerry] Context menu cannot be invoked after doing text selection in landscape mode
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (144208 => 144209)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2013-02-27 18:18:13 UTC (rev 144208)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2013-02-27 18:19:04 UTC (rev 144209)
@@ -740,9 +740,9 @@
}
#if ENABLE(FULLSCREEN_API)
-bool ChromeClientBlackBerry::supportsFullScreenForElement(const WebCore::Element* element, bool withKeyboard)
+bool ChromeClientBlackBerry::supportsFullScreenForElement(const WebCore::Element*, bool)
{
- return !withKeyboard;
+ return true;
}
void ChromeClientBlackBerry::enterFullScreenForElement(WebCore::Element* element)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
