Title: [144225] trunk/Source/WebKit/chromium
Revision
144225
Author
[email protected]
Date
2013-02-27 12:39:40 -0800 (Wed, 27 Feb 2013)

Log Message

[chromium] Remove suppression invalidation logic from WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=110999

Patch by James Robinson <[email protected]> on 2013-02-27
Reviewed by Adrienne Walker.

This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
by DumpRenderTree.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::scheduleComposite):
* src/WebViewImpl.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (144224 => 144225)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-27 20:38:31 UTC (rev 144224)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-27 20:39:40 UTC (rev 144225)
@@ -1,3 +1,19 @@
+2013-02-27  James Robinson  <[email protected]>
+
+        [chromium] Remove suppression invalidation logic from WebViewImpl
+        https://bugs.webkit.org/show_bug.cgi?id=110999
+
+        Reviewed by Adrienne Walker.
+
+        This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
+        by DumpRenderTree.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::WebViewImpl):
+        (WebKit::WebViewImpl::suppressInvalidations):
+        (WebKit::WebViewImpl::scheduleComposite):
+        * src/WebViewImpl.h:
+
 2013-02-27  Glenn Adams  <[email protected]>
 
         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (144224 => 144225)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-27 20:38:31 UTC (rev 144224)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2013-02-27 20:39:40 UTC (rev 144225)
@@ -453,7 +453,6 @@
     , m_flingModifier(0)
     , m_flingSourceDevice(false)
     , m_validationMessage(ValidationMessageClientImpl::create(*client))
-    , m_suppressInvalidations(false)
     , m_showFPSCounter(false)
     , m_showPaintRects(false)
     , m_showDebugBorders(false)
@@ -3983,7 +3982,6 @@
 
 void WebViewImpl::suppressInvalidations(bool enable)
 {
-    m_suppressInvalidations = enable;
     if (m_client)
         m_client->suppressCompositorScheduling(enable);
 }
@@ -4262,11 +4260,6 @@
 
 void WebViewImpl::scheduleComposite()
 {
-    if  (m_suppressInvalidations) {
-        TRACE_EVENT_INSTANT0("webkit", "WebViewImpl invalidations suppressed");
-        return;
-    }
-
     ASSERT(!Platform::current()->compositorSupport()->isThreadingEnabled());
     m_client->scheduleComposite();
 }

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (144224 => 144225)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-02-27 20:38:31 UTC (rev 144224)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h	2013-02-27 20:39:40 UTC (rev 144225)
@@ -899,8 +899,6 @@
 #endif
     OwnPtr<ValidationMessageClientImpl> m_validationMessage;
 
-    bool m_suppressInvalidations;
-
     bool m_showFPSCounter;
     bool m_showPaintRects;
     bool m_showDebugBorders;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to