Title: [144232] trunk/Source/WebCore
Revision
144232
Author
[email protected]
Date
2013-02-27 13:23:05 -0800 (Wed, 27 Feb 2013)

Log Message

Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=110937

Reviewed by Darin Adler.

This patch restores the ASSERT behind an ifdef so that we can continue
to get converage from the ASSERT while we investigate why it is
triggering in the threaded parser.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::checkLoadComplete):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (144231 => 144232)


--- trunk/Source/WebCore/ChangeLog	2013-02-27 21:20:38 UTC (rev 144231)
+++ trunk/Source/WebCore/ChangeLog	2013-02-27 21:23:05 UTC (rev 144232)
@@ -1,3 +1,17 @@
+2013-02-27  Adam Barth  <[email protected]>
+
+        Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
+        https://bugs.webkit.org/show_bug.cgi?id=110937
+
+        Reviewed by Darin Adler.
+
+        This patch restores the ASSERT behind an ifdef so that we can continue
+        to get converage from the ASSERT while we investigate why it is
+        triggering in the threaded parser.
+
+        * loader/DocumentLoader.cpp:
+        (WebCore::DocumentLoader::checkLoadComplete):
+
 2013-02-27  Lianghui Chen  <[email protected]>
 
         [BlackBerry] User credentials is not correctly handled

Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (144231 => 144232)


--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2013-02-27 21:20:38 UTC (rev 144231)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2013-02-27 21:23:05 UTC (rev 144232)
@@ -431,6 +431,11 @@
 {
     if (!m_frame || isLoading())
         return;
+#if !ENABLE(THREADED_HTML_PARSER)
+    // This ASSERT triggers with the threaded HTML parser.
+    // See https://bugs.webkit.org/show_bug.cgi?id=110937
+    ASSERT(this == frameLoader()->activeDocumentLoader());
+#endif
     m_frame->document()->domWindow()->finishedLoading();
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to