Title: [144253] trunk/Tools
- Revision
- 144253
- Author
- [email protected]
- Date
- 2013-02-27 17:33:44 -0800 (Wed, 27 Feb 2013)
Log Message
Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
https://bugs.webkit.org/show_bug.cgi?id=111021
Reviewed by Dirk Pranke.
The underlying code (which is shared with run-webkit-tests)
already knew how to support this option, it just wasn't exposed
via the run-perf-tests front-end. This patch fixes that.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (144252 => 144253)
--- trunk/Tools/ChangeLog 2013-02-28 00:56:45 UTC (rev 144252)
+++ trunk/Tools/ChangeLog 2013-02-28 01:33:44 UTC (rev 144253)
@@ -1,3 +1,17 @@
+2013-02-27 Eric Seidel <[email protected]>
+
+ Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
+ https://bugs.webkit.org/show_bug.cgi?id=111021
+
+ Reviewed by Dirk Pranke.
+
+ The underlying code (which is shared with run-webkit-tests)
+ already knew how to support this option, it just wasn't exposed
+ via the run-perf-tests front-end. This patch fixes that.
+
+ * Scripts/webkitpy/performance_tests/perftestsrunner.py:
+ (PerfTestsRunner._parse_args):
+
2013-02-27 Ryosuke Niwa <[email protected]>
Stop uploading results to webkit-perf.appspot.com
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (144252 => 144253)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2013-02-28 00:56:45 UTC (rev 144252)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2013-02-28 01:33:44 UTC (rev 144253)
@@ -124,6 +124,9 @@
help="Output per-test profile information."),
optparse.make_option("--profiler", action=""
help="Output per-test profile information, using the specified profiler."),
+ optparse.make_option("--additional-drt-flag", action=""
+ default=[], help="Additional command line flag to pass to DumpRenderTree "
+ "Specify multiple times to add multiple flags."),
]
return optparse.OptionParser(option_list=(perf_option_list)).parse_args(args)
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (144252 => 144253)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2013-02-28 00:56:45 UTC (rev 144252)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2013-02-28 01:33:44 UTC (rev 144253)
@@ -135,6 +135,8 @@
'--output-json-path=a/output.json',
'--slave-config-json-path=a/source.json',
'--test-results-server=somehost',
+ '--additional-drt-flag=--enable-threaded-parser',
+ '--additional-drt-flag=--awesomesauce',
'--debug'])
self.assertTrue(options.build)
self.assertEqual(options.build_directory, 'folder42')
@@ -148,6 +150,7 @@
self.assertEqual(options.output_json_path, 'a/output.json')
self.assertEqual(options.slave_config_json_path, 'a/source.json')
self.assertEqual(options.test_results_server, 'somehost')
+ self.assertEqual(options.additional_drt_flag, ['--enable-threaded-parser', '--awesomesauce'])
def test_upload_json(self):
runner, port = self.create_runner()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
