Modified: trunk/Source/_javascript_Core/ChangeLog (144364 => 144365)
--- trunk/Source/_javascript_Core/ChangeLog 2013-02-28 21:52:56 UTC (rev 144364)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-02-28 21:57:24 UTC (rev 144365)
@@ -1,3 +1,16 @@
+2013-02-28 Mark Hahnenberg <[email protected]>
+
+ Add casts in DFGGPRInfo.h to suppress warnings
+ https://bugs.webkit.org/show_bug.cgi?id=111104
+
+ Reviewed by Filip Pizlo.
+
+ With certain flags on, we get compiler warnings on ARM. We should do the proper casts to make these warnings go away.
+
+ * dfg/DFGGPRInfo.h:
+ (JSC::DFG::GPRInfo::toIndex):
+ (JSC::DFG::GPRInfo::debugName):
+
2013-02-28 Filip Pizlo <[email protected]>
It should be easy to determine if a DFG node exits forward or backward when doing type checks
Modified: trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h (144364 => 144365)
--- trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h 2013-02-28 21:52:56 UTC (rev 144364)
+++ trunk/Source/_javascript_Core/dfg/DFGGPRInfo.h 2013-02-28 21:57:24 UTC (rev 144365)
@@ -434,8 +434,8 @@
static unsigned toIndex(GPRReg reg)
{
- ASSERT(reg != InvalidGPRReg);
- ASSERT(reg < 16);
+ ASSERT(static_cast<unsigned>(reg) != InvalidGPRReg);
+ ASSERT(static_cast<unsigned>(reg) < 16);
static const unsigned indexForRegister[16] = { 0, 1, 2, InvalidIndex, 3, InvalidIndex, InvalidIndex, InvalidIndex, 4, 5, 6, 7, InvalidIndex, InvalidIndex, InvalidIndex, InvalidIndex };
unsigned result = indexForRegister[reg];
ASSERT(result != InvalidIndex);
@@ -444,8 +444,8 @@
static const char* debugName(GPRReg reg)
{
- ASSERT(reg != InvalidGPRReg);
- ASSERT(reg < 16);
+ ASSERT(static_cast<unsigned>(reg) != InvalidGPRReg);
+ ASSERT(static_cast<unsigned>(reg) < 16);
static const char* nameForRegister[16] = {
"r0", "r1", "r2", "r3",
"r4", "r5", "r6", "r7",
