Title: [144430] trunk/LayoutTests
Revision
144430
Author
[email protected]
Date
2013-03-01 01:45:46 -0800 (Fri, 01 Mar 2013)

Log Message

[Mac] [WK1] http/tests/xmlhttprequest/navigation-should-abort.html fails
https://bugs.webkit.org/show_bug.cgi?id=111052

Reviewed by Alexey Proskuryakov.

Currently, this test is failing to output the textual content of the
'data:' URL to which the test navigates. Replacing this 'data:' URL
with a "real" HTML file ensures that Mac WK1 behaves the same way as
the other ports for this test.

This doesn't really address the issue raised: navigation to a 'data:'
URL should behave in the same way as a "real" URL; filed
http://wkbug.com/111152 to track that issue.

* http/tests/xmlhttprequest/resources/navigation-target.html: Added.
    Add an actual file to which we can navigate.
* http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
* http/tests/xmlhttprequest/navigation-should-abort.html:
    Navigate to the new HTML file during the test rather than an inlined
    data: URL.
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
    Remove the expectations set in r144277.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (144429 => 144430)


--- trunk/LayoutTests/ChangeLog	2013-03-01 09:44:11 UTC (rev 144429)
+++ trunk/LayoutTests/ChangeLog	2013-03-01 09:45:46 UTC (rev 144430)
@@ -1,3 +1,29 @@
+2013-03-01  Mike West  <[email protected]>
+
+        [Mac] [WK1] http/tests/xmlhttprequest/navigation-should-abort.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=111052
+
+        Reviewed by Alexey Proskuryakov.
+
+        Currently, this test is failing to output the textual content of the
+        'data:' URL to which the test navigates. Replacing this 'data:' URL
+        with a "real" HTML file ensures that Mac WK1 behaves the same way as
+        the other ports for this test.
+
+        This doesn't really address the issue raised: navigation to a 'data:'
+        URL should behave in the same way as a "real" URL; filed
+        http://wkbug.com/111152 to track that issue.
+
+        * http/tests/xmlhttprequest/resources/navigation-target.html: Added.
+            Add an actual file to which we can navigate.
+        * http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
+        * http/tests/xmlhttprequest/navigation-should-abort.html:
+            Navigate to the new HTML file during the test rather than an inlined
+            data: URL.
+        * platform/mac-wk2/TestExpectations:
+        * platform/mac/TestExpectations:
+            Remove the expectations set in r144277.
+
 2013-03-01  Zan Dobersek  <[email protected]>
 
         Unreviewed GTK gardening.

Modified: trunk/LayoutTests/http/tests/xmlhttprequest/navigation-should-abort-expected.txt (144429 => 144430)


--- trunk/LayoutTests/http/tests/xmlhttprequest/navigation-should-abort-expected.txt	2013-03-01 09:44:11 UTC (rev 144429)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/navigation-should-abort-expected.txt	2013-03-01 09:45:46 UTC (rev 144430)
@@ -1,2 +1,2 @@
 CONSOLE MESSAGE: line 14: PASS: Expected 'abort', got 'abort'.
-This page should load, and the XMLHttpRequest from the previous page should have aborted and fired a 'PASS' message to the console.
+If this text shows up, you've successfully navigated to 'navigation-target.html'.

Modified: trunk/LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html (144429 => 144430)


--- trunk/LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html	2013-03-01 09:44:11 UTC (rev 144429)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html	2013-03-01 09:45:46 UTC (rev 144430)
@@ -16,8 +16,10 @@
         req.send(null);
 
         if (window.testRunner)
-            testRunner.queueLoad("data:text/html,<p>This page should load, and the XMLHttpRequest from the previous page should have aborted and fired a 'PASS' message to the console.</p>");
+            testRunner.queueLoad("resources/navigation-target.html");
     </script>
 </head>
 <body>
+    <p>This test requires TestRunner. To execute it manually, open the console, and navigate to <a href="" You should see a "PASS" message in the console.</p>
 </body>
+</html>

Added: trunk/LayoutTests/http/tests/xmlhttprequest/resources/navigation-target.html (0 => 144430)


--- trunk/LayoutTests/http/tests/xmlhttprequest/resources/navigation-target.html	                        (rev 0)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/resources/navigation-target.html	2013-03-01 09:45:46 UTC (rev 144430)
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <title>An navigation target, nothing more.</title>
+</head>
+<body>
+    <p>If this text shows up, you've successfully navigated to 'navigation-target.html'.</p>
+</body>
+</html>

Modified: trunk/LayoutTests/platform/mac/TestExpectations (144429 => 144430)


--- trunk/LayoutTests/platform/mac/TestExpectations	2013-03-01 09:44:11 UTC (rev 144429)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-03-01 09:45:46 UTC (rev 144430)
@@ -1452,5 +1452,3 @@
 
 # Need support for ResourceHandle::didChangePriority and DRT support
 webkit.org/b/111016 http/tests/loading/promote-img-preload-priority.html [ Failure ]
-
-webkit.org/b/111052 http/tests/xmlhttprequest/navigation-should-abort.html [ Failure ]

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (144429 => 144430)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-03-01 09:44:11 UTC (rev 144429)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-03-01 09:45:46 UTC (rev 144430)
@@ -313,8 +313,6 @@
 
 webkit.org/b/109890 [ Debug ] platform/mac-wk2/plugins/destroy-during-async-npp-new.html [ Crash ]
 
-webkit.org/b/111052 http/tests/xmlhttprequest/navigation-should-abort.html [ Pass ]
-
 ### END OF (1) Classified failures with bug reports
 ########################################
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to