Title: [144486] trunk/Source/_javascript_Core
- Revision
- 144486
- Author
- [email protected]
- Date
- 2013-03-01 12:57:37 -0800 (Fri, 01 Mar 2013)
Log Message
DFG Branch(LogicalNot) peephole should not try to optimize and work-around the case where LogicalNot may be otherwise live
https://bugs.webkit.org/show_bug.cgi?id=111209
Reviewed by Oliver Hunt.
Even if it is then everything will work just fine. It's not necessary to check the ref count here.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (144485 => 144486)
--- trunk/Source/_javascript_Core/ChangeLog 2013-03-01 20:49:51 UTC (rev 144485)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-03-01 20:57:37 UTC (rev 144486)
@@ -1,5 +1,17 @@
2013-03-01 Filip Pizlo <[email protected]>
+ DFG Branch(LogicalNot) peephole should not try to optimize and work-around the case where LogicalNot may be otherwise live
+ https://bugs.webkit.org/show_bug.cgi?id=111209
+
+ Reviewed by Oliver Hunt.
+
+ Even if it is then everything will work just fine. It's not necessary to check the ref count here.
+
+ * dfg/DFGFixupPhase.cpp:
+ (JSC::DFG::FixupPhase::fixupNode):
+
+2013-03-01 Filip Pizlo <[email protected]>
+
DFG CSE phase shouldn't rely on ref count of nodes, since it doesn't have to
https://bugs.webkit.org/show_bug.cgi?id=111205
Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (144485 => 144486)
--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2013-03-01 20:49:51 UTC (rev 144485)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2013-03-01 20:57:37 UTC (rev 144486)
@@ -493,8 +493,7 @@
fixDoubleEdge<NumberUse>(node->child1());
Node* logicalNot = node->child1().node();
- if (logicalNot->op() == LogicalNot
- && logicalNot->adjustedRefCount() == 1) {
+ if (logicalNot->op() == LogicalNot) {
// Make sure that OSR exit can't observe the LogicalNot. If it can,
// then we must compute it and cannot peephole around it.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
