Title: [144543] trunk/Source/WebCore
- Revision
- 144543
- Author
- [email protected]
- Date
- 2013-03-02 10:09:53 -0800 (Sat, 02 Mar 2013)
Log Message
constructTreeFromCompactHTMLToken should call clearExternalCharacters
https://bugs.webkit.org/show_bug.cgi?id=111248
Reviewed by Adam Barth.
I don't know how to write a test for this. It's possible characters()
is never accessed from HTMLStackItem::token(), but it's better to be
safe than sorry here.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144542 => 144543)
--- trunk/Source/WebCore/ChangeLog 2013-03-02 15:02:45 UTC (rev 144542)
+++ trunk/Source/WebCore/ChangeLog 2013-03-02 18:09:53 UTC (rev 144543)
@@ -1,3 +1,17 @@
+2013-03-02 Eric Seidel <[email protected]>
+
+ constructTreeFromCompactHTMLToken should call clearExternalCharacters
+ https://bugs.webkit.org/show_bug.cgi?id=111248
+
+ Reviewed by Adam Barth.
+
+ I don't know how to write a test for this. It's possible characters()
+ is never accessed from HTMLStackItem::token(), but it's better to be
+ safe than sorry here.
+
+ * html/parser/HTMLDocumentParser.cpp:
+ (WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
+
2013-03-02 Rob Buis <[email protected]>
Text overflow ellipsis wrong color when using webkit-text-fill-color
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (144542 => 144543)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-03-02 15:02:45 UTC (rev 144542)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-03-02 18:09:53 UTC (rev 144543)
@@ -570,6 +570,7 @@
{
RefPtr<AtomicHTMLToken> token = AtomicHTMLToken::create(compactToken);
m_treeBuilder->constructTree(token.get());
+ token->clearExternalCharacters(); // The compact token could be destroyed any time after this method returns.
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
