Title: [144550] trunk/Source/WebKit2
- Revision
- 144550
- Author
- [email protected]
- Date
- 2013-03-02 18:53:28 -0800 (Sat, 02 Mar 2013)
Log Message
WebKit2 is missing the setShowsURLsInToolTips preference
https://bugs.webkit.org/show_bug.cgi?id=111259
<rdar://problem/12991891>
Reviewed by Maciej Stachowiak.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShowsURLsInToolTipsEnabled):
(WKPreferencesGetShowsURLsInToolTipsEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe it through.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (144549 => 144550)
--- trunk/Source/WebKit2/ChangeLog 2013-03-03 01:45:58 UTC (rev 144549)
+++ trunk/Source/WebKit2/ChangeLog 2013-03-03 02:53:28 UTC (rev 144550)
@@ -1,3 +1,20 @@
+2013-03-02 Sam Weinig <[email protected]>
+
+ WebKit2 is missing the setShowsURLsInToolTips preference
+ https://bugs.webkit.org/show_bug.cgi?id=111259
+ <rdar://problem/12991891>
+
+ Reviewed by Maciej Stachowiak.
+
+ * Shared/WebPreferencesStore.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetShowsURLsInToolTipsEnabled):
+ (WKPreferencesGetShowsURLsInToolTipsEnabled):
+ * UIProcess/API/C/WKPreferencesPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+ Pipe it through.
+
2013-03-02 Benjamin Poulain <[email protected]>
Move computedStyleIncludingVisitedInfo from TestRunner to Internals
Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (144549 => 144550)
--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2013-03-03 01:45:58 UTC (rev 144549)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2013-03-03 02:53:28 UTC (rev 144550)
@@ -141,6 +141,7 @@
macro(LogsPageMessagesToSystemConsoleEnabled, logsPageMessagesToSystemConsoleEnabled, Bool, bool, false) \
macro(PageVisibilityBasedProcessSuppressionEnabled, pageVisibilityBasedProcessSuppressionEnabled, Bool, bool, false) \
macro(SmartInsertDeleteEnabled, smartInsertDeleteEnabled, Bool, bool, true) \
+ macro(ShowsURLsInToolTipsEnabled, showsURLsInToolTipsEnabled, Bool, bool, false) \
\
#define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (144549 => 144550)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2013-03-03 01:45:58 UTC (rev 144549)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2013-03-03 02:53:28 UTC (rev 144550)
@@ -1043,3 +1043,13 @@
{
return toImpl(preferencesRef)->smartInsertDeleteEnabled();
}
+
+void WKPreferencesSetShowsURLsInToolTipsEnabled(WKPreferencesRef preferencesRef, bool enabled)
+{
+ toImpl(preferencesRef)->setShowsURLsInToolTipsEnabled(enabled);
+}
+
+bool WKPreferencesGetShowsURLsInToolTipsEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->showsURLsInToolTipsEnabled();
+}
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h (144549 => 144550)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2013-03-03 01:45:58 UTC (rev 144549)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h 2013-03-03 02:53:28 UTC (rev 144550)
@@ -247,12 +247,17 @@
WK_EXPORT void WKPreferencesSetPageVisibilityBasedProcessSuppressionEnabled(WKPreferencesRef preferences, bool enabled);
WK_EXPORT bool WKPreferencesGetPageVisibilityBasedProcessSuppressionEnabled(WKPreferencesRef);
-WK_EXPORT void WKPreferencesResetTestRunnerOverrides(WKPreferencesRef preferencesRef);
-
// Defaults to true
WK_EXPORT void WKPreferencesSetSmartInsertDeleteEnabled(WKPreferencesRef preferences, bool enabled);
WK_EXPORT bool WKPreferencesGetSmartInsertDeleteEnabled(WKPreferencesRef preferences);
+// Defaults to false
+WK_EXPORT void WKPreferencesSetShowsURLsInToolTipsEnabled(WKPreferencesRef preferences, bool enabled);
+WK_EXPORT bool WKPreferencesGetShowsURLsInToolTipsEnabled(WKPreferencesRef preferences);
+
+
+WK_EXPORT void WKPreferencesResetTestRunnerOverrides(WKPreferencesRef preferencesRef);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (144549 => 144550)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2013-03-03 01:45:58 UTC (rev 144549)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2013-03-03 02:53:28 UTC (rev 144550)
@@ -2394,6 +2394,7 @@
settings->setLogsPageMessagesToSystemConsoleEnabled(store.getBoolValueForKey(WebPreferencesKey::logsPageMessagesToSystemConsoleEnabledKey()));
settings->setSmartInsertDeleteEnabled(store.getBoolValueForKey(WebPreferencesKey::smartInsertDeleteEnabledKey()));
+ settings->setShowsURLsInToolTips(store.getBoolValueForKey(WebPreferencesKey::showsURLsInToolTipsEnabledKey()));
platformPreferencesDidChange(store);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
