Title: [144591] trunk/Source/WebCore
- Revision
- 144591
- Author
- [email protected]
- Date
- 2013-03-03 16:16:35 -0800 (Sun, 03 Mar 2013)
Log Message
[V8] HTMLDocument.all should have [Replaceable]
https://bugs.webkit.org/show_bug.cgi?id=111230
Reviewed by Adam Barth.
(Although HTMLDocument.all is already removed from the spec,)
it is expected to behave as a [Replaceable] attribute. By adding
a [Replaceable] IDL attribute, we can remove custom implementation
of HTMLDocument.all.
I confimed that exactly the same code is generated for .all getter
and setter.
No tests. No change in behavior.
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
* html/HTMLDocument.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144590 => 144591)
--- trunk/Source/WebCore/ChangeLog 2013-03-04 00:12:06 UTC (rev 144590)
+++ trunk/Source/WebCore/ChangeLog 2013-03-04 00:16:35 UTC (rev 144591)
@@ -1,5 +1,25 @@
2013-03-01 Kentaro Hara <[email protected]>
+ [V8] HTMLDocument.all should have [Replaceable]
+ https://bugs.webkit.org/show_bug.cgi?id=111230
+
+ Reviewed by Adam Barth.
+
+ (Although HTMLDocument.all is already removed from the spec,)
+ it is expected to behave as a [Replaceable] attribute. By adding
+ a [Replaceable] IDL attribute, we can remove custom implementation
+ of HTMLDocument.all.
+
+ I confimed that exactly the same code is generated for .all getter
+ and setter.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+ * html/HTMLDocument.idl:
+
+2013-03-01 Kentaro Hara <[email protected]>
+
[V8] indexedSecurityCheck() and namedSecurityCheck() should be auto-generated
https://bugs.webkit.org/show_bug.cgi?id=111225
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp (144590 => 144591)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp 2013-03-04 00:12:06 UTC (rev 144590)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp 2013-03-04 00:16:35 UTC (rev 144591)
@@ -138,12 +138,6 @@
return args.Holder();
}
-void V8HTMLDocument::allAttrSetterCustom(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
-{
- // Just emulate a normal JS behaviour---install a property on this.
- info.This()->ForceSet(name, value);
-}
-
v8::Handle<v8::Object> wrap(HTMLDocument* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
Modified: trunk/Source/WebCore/html/HTMLDocument.idl (144590 => 144591)
--- trunk/Source/WebCore/html/HTMLDocument.idl 2013-03-04 00:12:06 UTC (rev 144590)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2013-03-04 00:16:35 UTC (rev 144591)
@@ -36,7 +36,7 @@
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// FIXME: This should eventually be available (if they are wanted) for all languages.
- [JSCustomGetter, CustomSetter, Deletable] attribute HTMLAllCollection all;
+ [JSCustom, Replaceable, Deletable] attribute HTMLAllCollection all;
#endif
void clear();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
