Title: [144596] trunk
- Revision
- 144596
- Author
- [email protected]
- Date
- 2013-03-03 22:28:55 -0800 (Sun, 03 Mar 2013)
Log Message
[Mac] Get rid of a useless method from DOMHTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=111279
Reviewed by Sam Weinig.
Source/WebKit/mac:
* DOM/WebDOMOperations.mm:
* DOM/WebDOMOperationsPrivate.h:
setValueForUser: is already privately exposed by DOMHTMLInputElement,
no need to have it twice.
Tools:
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setValueForUser):
The method _setValueForUser: was added for testing. This feature is already
exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
in real use cases. Get rid of the method created for testing, use the real thing
instead.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (144595 => 144596)
--- trunk/Source/WebKit/mac/ChangeLog 2013-03-04 05:51:46 UTC (rev 144595)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-03-04 06:28:55 UTC (rev 144596)
@@ -1,3 +1,15 @@
+2013-03-03 Benjamin Poulain <[email protected]>
+
+ [Mac] Get rid of a useless method from DOMHTMLInputElement
+ https://bugs.webkit.org/show_bug.cgi?id=111279
+
+ Reviewed by Sam Weinig.
+
+ * DOM/WebDOMOperations.mm:
+ * DOM/WebDOMOperationsPrivate.h:
+ setValueForUser: is already privately exposed by DOMHTMLInputElement,
+ no need to have it twice.
+
2013-03-03 Adam Barth <[email protected]>
Unreviewed attempted build fix. Adds back some includes removed in
Modified: trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm (144595 => 144596)
--- trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm 2013-03-04 05:51:46 UTC (rev 144595)
+++ trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm 2013-03-04 06:28:55 UTC (rev 144596)
@@ -237,11 +237,6 @@
static_cast<HTMLInputElement*>(core((DOMElement *)self))->setAutofilled(autofilled);
}
-- (void)_setValueForUser:(NSString *)value
-{
- static_cast<HTMLInputElement*>(core((DOMElement *)self))->setValueForUser(value);
-}
-
@end
@implementation DOMHTMLObjectElement (WebDOMHTMLObjectElementOperations)
Modified: trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h (144595 => 144596)
--- trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h 2013-03-04 05:51:46 UTC (rev 144595)
+++ trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h 2013-03-04 06:28:55 UTC (rev 144596)
@@ -39,7 +39,6 @@
@interface DOMHTMLInputElement (WebDOMHTMLInputElementOperationsPrivate)
- (void)_setAutofilled:(BOOL)autofilled;
-- (void)_setValueForUser:(NSString *)value;
@end
@interface DOMNode (WebDOMNodeOperationsPendingPublic)
Modified: trunk/Tools/ChangeLog (144595 => 144596)
--- trunk/Tools/ChangeLog 2013-03-04 05:51:46 UTC (rev 144595)
+++ trunk/Tools/ChangeLog 2013-03-04 06:28:55 UTC (rev 144596)
@@ -1,3 +1,17 @@
+2013-03-03 Benjamin Poulain <[email protected]>
+
+ [Mac] Get rid of a useless method from DOMHTMLInputElement
+ https://bugs.webkit.org/show_bug.cgi?id=111279
+
+ Reviewed by Sam Weinig.
+
+ * DumpRenderTree/mac/TestRunnerMac.mm:
+ (TestRunner::setValueForUser):
+ The method _setValueForUser: was added for testing. This feature is already
+ exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
+ in real use cases. Get rid of the method created for testing, use the real thing
+ instead.
+
2013-03-03 Ryosuke Niwa <[email protected]>
Some perf. tests have variances that differ greatly between runs
Modified: trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm (144595 => 144596)
--- trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2013-03-04 05:51:46 UTC (rev 144595)
+++ trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2013-03-04 06:28:55 UTC (rev 144596)
@@ -45,6 +45,7 @@
#import <WebCore/GeolocationPosition.h>
#import <WebKit/DOMDocument.h>
#import <WebKit/DOMElement.h>
+#import <WebKit/DOMHTMLInputElementPrivate.h>
#import <WebKit/WebApplicationCache.h>
#import <WebKit/WebBackForwardList.h>
#import <WebKit/WebCoreStatistics.h>
@@ -587,7 +588,7 @@
return;
RetainPtr<CFStringRef> valueCF(AdoptCF, JSStringCopyCFString(kCFAllocatorDefault, value));
- [(DOMHTMLInputElement *)element _setValueForUser:(NSString *)valueCF.get()];
+ [(DOMHTMLInputElement *)element setValueForUser:(NSString *)valueCF.get()];
}
void TestRunner::setViewModeMediaFeature(JSStringRef mode)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
