Title: [144659] trunk/Source/WebKit2
- Revision
- 144659
- Author
- [email protected]
- Date
- 2013-03-04 12:33:42 -0800 (Mon, 04 Mar 2013)
Log Message
Complete the plug-in URL string before sending it to the UI process
https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>
Reviewed by Andreas Kling.
If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (144658 => 144659)
--- trunk/Source/WebKit2/ChangeLog 2013-03-04 20:22:45 UTC (rev 144658)
+++ trunk/Source/WebKit2/ChangeLog 2013-03-04 20:33:42 UTC (rev 144659)
@@ -1,3 +1,16 @@
+2013-03-04 Anders Carlsson <[email protected]>
+
+ Complete the plug-in URL string before sending it to the UI process
+ https://bugs.webkit.org/show_bug.cgi?id=111355
+ <rdar://problem/13326713>
+
+ Reviewed by Andreas Kling.
+
+ If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.
+
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::unavailablePluginButtonClicked):
+
2013-03-04 Carlos Garcia Campos <[email protected]>
[GTK] Some WebKit2 GTK+ unit tests are failing in 32 bits bot
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (144658 => 144659)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2013-03-04 20:22:45 UTC (rev 144658)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2013-03-04 20:33:42 UTC (rev 144659)
@@ -501,10 +501,11 @@
String frameURLString = pluginElement->document()->frame()->loader()->documentLoader()->responseURL().string();
String pageURLString = m_page->mainFrame()->loader()->documentLoader()->responseURL().string();
+ String pluginURLString = pluginElement->document()->completeURL(pluginElement->url()).string();
KURL pluginspageAttributeURL = element->document()->completeURL(stripLeadingAndTrailingHTMLSpaces(pluginElement->getAttribute(pluginspageAttr)));
if (!pluginspageAttributeURL.protocolIsInHTTPFamily())
pluginspageAttributeURL = KURL();
- m_page->send(Messages::WebPageProxy::UnavailablePluginButtonClicked(pluginUnavailabilityReason, pluginElement->serviceType(), pluginElement->url(), pluginspageAttributeURL.string(), frameURLString, pageURLString));
+ m_page->send(Messages::WebPageProxy::UnavailablePluginButtonClicked(pluginUnavailabilityReason, pluginElement->serviceType(), pluginURLString, pluginspageAttributeURL.string(), frameURLString, pageURLString));
}
void WebChromeClient::scrollbarsModeDidChange() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
