Title: [144738] trunk/Source/WebCore
- Revision
- 144738
- Author
- [email protected]
- Date
- 2013-03-05 00:31:43 -0800 (Tue, 05 Mar 2013)
Log Message
[V8] Remove unused custom indexedPropertyGetter
https://bugs.webkit.org/show_bug.cgi?id=111409
Patch by Koji Hara <[email protected]> on 2013-03-05
Reviewed by Kentaro Hara.
Remove unused custom indexedPropertyGetter.
There are 9 custom indexedPropertyGetter, including an unused one(NamedNodeMap).
This commit assures all existing custom indexedPropertyGetter(for V8) are used.
No new tests. Simple refactoring.
* bindings/v8/custom/V8NamedNodeMapCustom.cpp: Remove indexedPropertyGetter
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144737 => 144738)
--- trunk/Source/WebCore/ChangeLog 2013-03-05 08:30:57 UTC (rev 144737)
+++ trunk/Source/WebCore/ChangeLog 2013-03-05 08:31:43 UTC (rev 144738)
@@ -1,3 +1,18 @@
+2013-03-05 Koji Hara <[email protected]>
+
+ [V8] Remove unused custom indexedPropertyGetter
+ https://bugs.webkit.org/show_bug.cgi?id=111409
+
+ Reviewed by Kentaro Hara.
+
+ Remove unused custom indexedPropertyGetter.
+ There are 9 custom indexedPropertyGetter, including an unused one(NamedNodeMap).
+ This commit assures all existing custom indexedPropertyGetter(for V8) are used.
+
+ No new tests. Simple refactoring.
+
+ * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Remove indexedPropertyGetter
+
2013-03-05 Hajime Morrita <[email protected]>
ShadowRoot needs guardRef() and guardDeref()
Modified: trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp (144737 => 144738)
--- trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp 2013-03-05 08:30:57 UTC (rev 144737)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp 2013-03-05 08:31:43 UTC (rev 144738)
@@ -42,16 +42,6 @@
namespace WebCore {
-v8::Handle<v8::Value> V8NamedNodeMap::indexedPropertyGetter(uint32_t index, const v8::AccessorInfo& info)
-{
- NamedNodeMap* imp = V8NamedNodeMap::toNative(info.Holder());
- RefPtr<Node> result = imp->item(index);
- if (!result)
- return v8Undefined();
-
- return toV8Fast(result.release(), info, imp);
-}
-
v8::Handle<v8::Value> V8NamedNodeMap::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes