Title: [144771] trunk/Source/WebKit/blackberry
- Revision
- 144771
- Author
- [email protected]
- Date
- 2013-03-05 09:54:31 -0800 (Tue, 05 Mar 2013)
Log Message
[BlackBerry] FatFinger pairs the wrong element with fatfinger rect part.
https://bugs.webkit.org/show_bug.cgi?id=111444
Patch by Tiancheng Jiang <[email protected]> on 2013-03-05
Reviewed by Rob Buis.
Internal PR 266214
Internally reviewed by Genevieve Mak.
Instead of subtracting with the element region, we should get the remaining
rect by find the intersect region of element region and fatfinger detection
region.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::checkForClickableElement):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (144770 => 144771)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-03-05 17:42:47 UTC (rev 144770)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-03-05 17:54:31 UTC (rev 144771)
@@ -1,3 +1,21 @@
+2013-03-05 Tiancheng Jiang <[email protected]>
+
+ [BlackBerry] FatFinger pairs the wrong element with fatfinger rect part.
+ https://bugs.webkit.org/show_bug.cgi?id=111444
+
+ Reviewed by Rob Buis.
+
+ Internal PR 266214
+ Internally reviewed by Genevieve Mak.
+
+ Instead of subtracting with the element region, we should get the remaining
+ rect by find the intersect region of element region and fatfinger detection
+ region.
+
+
+ * WebKitSupport/FatFingers.cpp:
+ (BlackBerry::WebKit::FatFingers::checkForClickableElement):
+
2013-03-05 Andrew Lo <[email protected]>
[BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp (144770 => 144771)
--- trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2013-03-05 17:42:47 UTC (rev 144770)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2013-03-05 17:54:31 UTC (rev 144771)
@@ -374,12 +374,12 @@
if (curElementRenderLayer != lowestPositionedEnclosingLayerSoFar) {
// elementRegion will always be in contents coordinates of its container frame. It needs to be
- // mapped to main frame contents coordinates in order to subtract the fingerRegion, then.
+ // mapped to main frame contents coordinates in order to intersect the fingerRegion, then.
WebCore::IntPoint framePos(m_webPage->frameOffset(curElement->document()->frame()));
IntRectRegion layerRegion(Platform::IntRect(lowestPositionedEnclosingLayerSoFar->renderer()->absoluteBoundingBoxRect(true/*use transforms*/)));
layerRegion.move(framePos.x(), framePos.y());
- remainingFingerRegion = subtractRegions(remainingFingerRegion, layerRegion);
+ remainingFingerRegion = intersectRegions(remainingFingerRegion, layerRegion);
lowestPositionedEnclosingLayerSoFar = curElementRenderLayer;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
