Title: [144972] trunk/Source/WebCore
- Revision
- 144972
- Author
- [email protected]
- Date
- 2013-03-06 13:21:48 -0800 (Wed, 06 Mar 2013)
Log Message
Threaded HTML parser should use 8 bit strings for attributes
https://bugs.webkit.org/show_bug.cgi?id=111610
Reviewed by Eric Seidel.
This fixes a 27% regression in dromaeo_jslibattrjquery on the threaded HTML parser vs. the main thread parser.
No new tests because no new functionality.
* html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144971 => 144972)
--- trunk/Source/WebCore/ChangeLog 2013-03-06 21:16:45 UTC (rev 144971)
+++ trunk/Source/WebCore/ChangeLog 2013-03-06 21:21:48 UTC (rev 144972)
@@ -1,3 +1,17 @@
+2013-03-06 Tony Gentilcore <[email protected]>
+
+ Threaded HTML parser should use 8 bit strings for attributes
+ https://bugs.webkit.org/show_bug.cgi?id=111610
+
+ Reviewed by Eric Seidel.
+
+ This fixes a 27% regression in dromaeo_jslibattrjquery on the threaded HTML parser vs. the main thread parser.
+
+ No new tests because no new functionality.
+
+ * html/parser/CompactHTMLToken.cpp:
+ (WebCore::CompactHTMLToken::CompactHTMLToken):
+
2013-03-06 Alpha Lam <[email protected]>
More cleanup in GIFImageReader
Modified: trunk/Source/WebCore/html/parser/CompactHTMLToken.cpp (144971 => 144972)
--- trunk/Source/WebCore/html/parser/CompactHTMLToken.cpp 2013-03-06 21:16:45 UTC (rev 144971)
+++ trunk/Source/WebCore/html/parser/CompactHTMLToken.cpp 2013-03-06 21:21:48 UTC (rev 144972)
@@ -67,9 +67,8 @@
break;
case HTMLToken::StartTag:
m_attributes.reserveInitialCapacity(token->attributes().size());
- // FIXME: Attribute names and values should be 8bit when possible.
for (Vector<HTMLToken::Attribute>::const_iterator it = token->attributes().begin(); it != token->attributes().end(); ++it)
- m_attributes.append(Attribute(String(it->name), String(it->value)));
+ m_attributes.append(Attribute(StringImpl::create8BitIfPossible(it->name), StringImpl::create8BitIfPossible(it->value)));
// Fall through!
case HTMLToken::EndTag:
m_selfClosing = token->selfClosing();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
