Title: [145001] trunk
- Revision
- 145001
- Author
- [email protected]
- Date
- 2013-03-06 16:26:01 -0800 (Wed, 06 Mar 2013)
Log Message
Full screen from an iframe with a z-index style will allow siblings with higher z-index to overlay full screen content.
https://bugs.webkit.org/show_bug.cgi?id=111637
Reviewed by Simon Fraser.
Source/WebCore:
No new tests; updated fullscreen/full-screen-iframe-zIndex.html to expose bug.
Pages with explicit z-index: styles on their iframes will override the default z-index: UA style when
elements within that iframe enter full screen mode. Mark the UA style as !important so as to not allow
iframe siblings with higher z-index styles to overlay the full screen element.
* css/fullscreen.css:
(:-webkit-full-screen):
LayoutTests:
* fullscreen/full-screen-iframe-zIndex.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (145000 => 145001)
--- trunk/LayoutTests/ChangeLog 2013-03-07 00:25:20 UTC (rev 145000)
+++ trunk/LayoutTests/ChangeLog 2013-03-07 00:26:01 UTC (rev 145001)
@@ -1,3 +1,12 @@
+2013-03-06 Jer Noble <[email protected]>
+
+ Full screen from an iframe with a z-index style will allow siblings with higher z-index to overlay full screen content.
+ https://bugs.webkit.org/show_bug.cgi?id=111637
+
+ Reviewed by Simon Fraser.
+
+ * fullscreen/full-screen-iframe-zIndex.html:
+
2013-03-06 Ryosuke Niwa <[email protected]>
editing/pasteboard/paste-4035648-fix.html should be a dump-as-markup test
Modified: trunk/LayoutTests/fullscreen/full-screen-iframe-zIndex.html (145000 => 145001)
--- trunk/LayoutTests/fullscreen/full-screen-iframe-zIndex.html 2013-03-07 00:25:20 UTC (rev 145000)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-zIndex.html 2013-03-07 00:26:01 UTC (rev 145001)
@@ -30,6 +30,7 @@
height: 100px;
border: 4px solid darkgreen;
background-color: green;
+ z-index: 0;
}
#block2 {
width: 100px;
Modified: trunk/Source/WebCore/ChangeLog (145000 => 145001)
--- trunk/Source/WebCore/ChangeLog 2013-03-07 00:25:20 UTC (rev 145000)
+++ trunk/Source/WebCore/ChangeLog 2013-03-07 00:26:01 UTC (rev 145001)
@@ -1,3 +1,19 @@
+2013-03-06 Jer Noble <[email protected]>
+
+ Full screen from an iframe with a z-index style will allow siblings with higher z-index to overlay full screen content.
+ https://bugs.webkit.org/show_bug.cgi?id=111637
+
+ Reviewed by Simon Fraser.
+
+ No new tests; updated fullscreen/full-screen-iframe-zIndex.html to expose bug.
+
+ Pages with explicit z-index: styles on their iframes will override the default z-index: UA style when
+ elements within that iframe enter full screen mode. Mark the UA style as !important so as to not allow
+ iframe siblings with higher z-index styles to overlay the full screen element.
+
+ * css/fullscreen.css:
+ (:-webkit-full-screen):
+
2013-03-06 Levi Weintraub <[email protected]>
InsertUnorderedList can lead to lost content and assertions in moveParagraphs
Modified: trunk/Source/WebCore/css/fullscreen.css (145000 => 145001)
--- trunk/Source/WebCore/css/fullscreen.css 2013-03-07 00:25:20 UTC (rev 145000)
+++ trunk/Source/WebCore/css/fullscreen.css 2013-03-07 00:26:01 UTC (rev 145001)
@@ -1,6 +1,6 @@
:-webkit-full-screen {
background-color: white;
- z-index: 2147483647;
+ z-index: 2147483647 !important;
}
:root:-webkit-full-screen-document:not(:-webkit-full-screen), :root:-webkit-full-screen-ancestor {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
