Title: [145036] trunk
- Revision
- 145036
- Author
- [email protected]
- Date
- 2013-03-06 21:49:15 -0800 (Wed, 06 Mar 2013)
Log Message
Unreviewed, rolling out r144726.
http://trac.webkit.org/changeset/144726
https://bugs.webkit.org/show_bug.cgi?id=111681
caused performance regression for Dromaeo attribute tests.
(Requested by arpitab on #webkit).
Patch by Sheriff Bot <[email protected]> on 2013-03-06
Source/WebCore:
* dom/Element.h:
(WebCore::ElementData::getAttributeItemIndex):
LayoutTests:
* fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Removed.
* fast/dom/Element/getAttribute-case-insensitivity.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (145035 => 145036)
--- trunk/LayoutTests/ChangeLog 2013-03-07 05:20:29 UTC (rev 145035)
+++ trunk/LayoutTests/ChangeLog 2013-03-07 05:49:15 UTC (rev 145036)
@@ -1,3 +1,15 @@
+2013-03-06 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r144726.
+ http://trac.webkit.org/changeset/144726
+ https://bugs.webkit.org/show_bug.cgi?id=111681
+
+ caused performance regression for Dromaeo attribute tests.
+ (Requested by arpitab on #webkit).
+
+ * fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Removed.
+ * fast/dom/Element/getAttribute-case-insensitivity.html: Removed.
+
2013-03-05 Kinuko Yasuda <[email protected]>
File.lastModifiedDate() should return the current date/time if the file date/time is not available
Deleted: trunk/LayoutTests/fast/dom/Element/getAttribute-case-insensitivity-expected.txt (145035 => 145036)
--- trunk/LayoutTests/fast/dom/Element/getAttribute-case-insensitivity-expected.txt 2013-03-07 05:20:29 UTC (rev 145035)
+++ trunk/LayoutTests/fast/dom/Element/getAttribute-case-insensitivity-expected.txt 2013-03-07 05:49:15 UTC (rev 145036)
@@ -1,15 +0,0 @@
-Test for Bugzilla bug: 105713: getAttribute does not behave correctly for mixed-case attributes on HTML testements.
-This test verifies that the getAttribute() and the getAttributeNode() APIs convert the passed attribute name to lowercase before comparing against existing attributes.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-PASS test.getAttribute('NEWATTR') is 'PASS'
-PASS test.getAttributeNode('NEWATTR').value is 'PASS'
-PASS test.getAttributeNS(null, 'NEWATTR') is 'FAIL'
-PASS test.getAttribute('newattr') is 'PASS'
-PASS test.getAttributeNode('newattr').value is 'PASS'
-PASS test.getAttributeNS(null, 'newattr') is 'PASS'
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/dom/Element/getAttribute-case-insensitivity.html (145035 => 145036)
--- trunk/LayoutTests/fast/dom/Element/getAttribute-case-insensitivity.html 2013-03-07 05:20:29 UTC (rev 145035)
+++ trunk/LayoutTests/fast/dom/Element/getAttribute-case-insensitivity.html 2013-03-07 05:49:15 UTC (rev 145036)
@@ -1,32 +0,0 @@
-<html>
-<head>
-<script src=""
-<script>
-function runTest()
-{
- description("This test verifies that the getAttribute() and the getAttributeNode() APIs convert the passed attribute name to lowercase before comparing against existing attributes.");
-
- var test = document.getElementById("test");
- test.setAttributeNS(null, "NEWATTR", "FAIL");
- test.setAttributeNS(null, "newattr", "PASS");
-
- if (window.testRunner) {
- shouldBe("test.getAttribute('NEWATTR')", "'PASS'");
- shouldBe("test.getAttributeNode('NEWATTR').value", "'PASS'");
- shouldBe("test.getAttributeNS(null, 'NEWATTR')", "'FAIL'");
- shouldBe("test.getAttribute('newattr')", "'PASS'");
- shouldBe("test.getAttributeNode('newattr').value", "'PASS'");
- shouldBe("test.getAttributeNS(null, 'newattr')", "'PASS'");
-
- isSuccessfullyParsed();
- }
-}
-</script>
-</head>
-<body _onload_="runTest()">
-<div>Test for Bugzilla bug:<a href="" 105713:</a> getAttribute does not behave correctly for mixed-case attributes on HTML testements.</div>
-<div id="test"></div>
-<div id="description"></div>
-<div id="console"></div>
-</body>
-</html>
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (145035 => 145036)
--- trunk/Source/WebCore/ChangeLog 2013-03-07 05:20:29 UTC (rev 145035)
+++ trunk/Source/WebCore/ChangeLog 2013-03-07 05:49:15 UTC (rev 145036)
@@ -1,3 +1,15 @@
+2013-03-06 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r144726.
+ http://trac.webkit.org/changeset/144726
+ https://bugs.webkit.org/show_bug.cgi?id=111681
+
+ caused performance regression for Dromaeo attribute tests.
+ (Requested by arpitab on #webkit).
+
+ * dom/Element.h:
+ (WebCore::ElementData::getAttributeItemIndex):
+
2013-03-04 Kinuko Yasuda <[email protected]>
File.lastModifiedDate() should return the current date/time if the file date/time is not available
Modified: trunk/Source/WebCore/dom/Element.h (145035 => 145036)
--- trunk/Source/WebCore/dom/Element.h 2013-03-07 05:20:29 UTC (rev 145035)
+++ trunk/Source/WebCore/dom/Element.h 2013-03-07 05:49:15 UTC (rev 145036)
@@ -941,7 +941,7 @@
for (unsigned i = 0; i < len; ++i) {
const Attribute* attribute = attributeItem(i);
if (!attribute->name().hasPrefix()) {
- if ((shouldIgnoreAttributeCase ? name.lower() : name) == attribute->localName())
+ if (name == attribute->localName())
return i;
} else
doSlowCheck = true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
