Title: [145042] trunk/Source/WebKit2
- Revision
- 145042
- Author
- [email protected]
- Date
- 2013-03-06 23:25:20 -0800 (Wed, 06 Mar 2013)
Log Message
SandboxExtension::createHandle raises an uncaught Objective-C exception if path is empty
https://bugs.webkit.org/show_bug.cgi?id=111689
Reviewed by Filip Pizlo.
* Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle):
Use a function from WebCore platform layer instead of Foundation one equivalent.
We already do this elsewhere in this file.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (145041 => 145042)
--- trunk/Source/WebKit2/ChangeLog 2013-03-07 06:47:21 UTC (rev 145041)
+++ trunk/Source/WebKit2/ChangeLog 2013-03-07 07:25:20 UTC (rev 145042)
@@ -1,3 +1,14 @@
+2013-03-06 Alexey Proskuryakov <[email protected]>
+
+ SandboxExtension::createHandle raises an uncaught Objective-C exception if path is empty
+ https://bugs.webkit.org/show_bug.cgi?id=111689
+
+ Reviewed by Filip Pizlo.
+
+ * Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle):
+ Use a function from WebCore platform layer instead of Foundation one equivalent.
+ We already do this elsewhere in this file.
+
2013-03-06 Tim Horton <[email protected]>
[wk2] Page overlays shouldn't dirty the entire layer when flushing if the main frame can't scroll
Modified: trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm (145041 => 145042)
--- trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm 2013-03-07 06:47:21 UTC (rev 145041)
+++ trunk/Source/WebKit2/Shared/mac/SandboxExtensionMac.mm 2013-03-07 07:25:20 UTC (rev 145042)
@@ -214,7 +214,8 @@
{
ASSERT(!handle.m_sandboxExtension);
- CString standardizedPath = resolveSymlinksInPath([[(NSString *)path stringByStandardizingPath] fileSystemRepresentation]);
+ // FIXME: Do we need both resolveSymlinksInPath() and -stringByStandardizingPath?
+ CString standardizedPath = resolveSymlinksInPath(fileSystemRepresentation([(NSString *)path stringByStandardizingPath]));
handle.m_sandboxExtension = WKSandboxExtensionCreate(standardizedPath.data(), wkSandboxExtensionType(type));
if (!handle.m_sandboxExtension)
WTFLogAlways("Could not create a sandbox extension for '%s'", path.utf8().data());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
